Add auto pkg & run react runtimes tests against auto & transform runtimes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 907e043 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -470 B (-1%) Total Size: 83.6 kB
ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Nov 21, 2023
andrewiggins
commented
Nov 21, 2023
Comment on lines
-11
to
-12
| import { useSignal, useComputed, useSignalEffect } from "../runtime"; | ||
| import { installAutoSignalTracking } from "../runtime/src/auto"; |
There was a problem hiding this comment.
This double import caused some duplicate code in the final bundle. Combining them is what caused this PR to reduce the overall bundle size shown in the size-bot comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto package (not exported yet though) in preparation for next major release that will make auto runtime opt-in
Run
@preact/signals-reacttest suite against test files using the auto and transform runtimes to verify each runtime's behavior.