Introduce react-utils package #627
Open
+173
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoviDeCroock
force-pushed
the
add-react-utils
branch
from
8e3c3a6 to
9553208
Compare
🦋 Changeset detectedLatest commit: a278750 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Dec 13, 2024
JoviDeCroock
force-pushed
the
add-react-utils
branch
from
9553208 to
0a31ce9
Compare
JoviDeCroock
commented
Dec 13, 2024
|
|
||
| export function For<T>(props: ForProps<T>): JSX.Element | null { | ||
| useSignals(); | ||
| const cache = useMemo(() => new Map(), []); |
There was a problem hiding this comment.
We might need to switch this to a WeakMap when we see the first item being an object or leverage JSON.stringify on objects
JoviDeCroock
force-pushed
the
add-react-utils
branch
from
0a31ce9 to
1134132
Compare
JoviDeCroock
force-pushed
the
add-react-utils
branch
from
1134132 to
0df78b9
Compare
|
Size Change: 0 B Total Size: 83.3 kB ℹ️ View Unchanged
|
rschristian
reviewed
Dec 17, 2024
|
|
||
| interface ShowProps<T = boolean> { | ||
| when: Signal<T> | ReadonlySignal<T>; | ||
| fallback?: JSX.Element; |
There was a problem hiding this comment.
I think we need to switch to importing JSX, it's (finally!) no longer a global in React 19 AFAIK. It should exist on the React namespace back to 16.
|
@rschristian we will offer it for both but started out with React as the 2.0 release was pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some common utilities for leveraging JSX with signals, I tried to stay in line with how
solidprovides JSX utils.