fix tmpFile closing

prebid · Jan 16, 2025 · a7cbc33 · a7cbc33
1 parent 9794643
commit a7cbc33
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...rg/prebid/server/hooks/modules/greenbids/real/time/data/config/DatabaseReaderFactory.java b/...rg/prebid/server/hooks/modules/greenbids/real/time/data/config/DatabaseReaderFactory.java
@@ -63,9 +63,8 @@ private Future<DatabaseReader> downloadAndExtract() {
     private Future<Void> downloadFile(String downloadUrl, String tmpPath) {
         return fileSystem.open(tmpPath, new OpenOptions())
                 .compose(tmpFile -> sendHttpRequest(downloadUrl)
-                        .compose(response -> response.pipeTo(tmpFile))
-                        .onFailure(error -> logger.error(
-                                "Failed to download file from {} to {}.", downloadUrl, tmpPath, error)));
+                        .onFailure(ignore -> tmpFile.close())
+                        .compose(response -> response.pipeTo(tmpFile)));
     }
 
     private Future<HttpClientResponse> sendHttpRequest(String url) {

diff --git a/src/main/java/org/prebid/server/execution/file/supplier/RemoteFileSupplier.java b/src/main/java/org/prebid/server/execution/file/supplier/RemoteFileSupplier.java
@@ -96,6 +96,7 @@ private Future<Boolean> isSizeChanged() {
     private Future<Void> downloadFile() {
         return fileSystem.open(tmpPath, new OpenOptions())
                 .compose(tmpFile -> sendHttpRequest(getRequestOptions)
+                        .onFailure(ignore -> tmpFile.close())
                         .compose(response -> response.pipeTo(tmpFile))
                         .onComplete(result -> tmpFile.close()));
     }