Adverxo: New adapter ported from Go #3705
Open
+1,463
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AntoxaAntoxic, can You check my adapter because I have problem with AdverxoTest |
AntoxaAntoxic
requested changes
Feb 11, 2025
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/proto/openrtb/ext/request/adverxo/ExtImpAdverxo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/adverxo/AdverxoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/adverxo/AdverxoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/adverxo/AdverxoBidderTest.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Feb 14, 2025
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Feb 19, 2025
AntoxaAntoxic
requested changes
Feb 19, 2025
AntoxaAntoxic
previously approved these changes
Feb 21, 2025
osulzhenko
changed the title
CTMBNara
requested changes
Mar 4, 2025
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adverxo/AdverxoBidder.java
Outdated
Show resolved
Hide resolved
Comment on lines
+7
to
+8
| @Value | ||
| @AllArgsConstructor(staticName = "of") |
There was a problem hiding this comment.
@Value(staticConstructor = "of")
|
|
||
| @JsonProperty("adUnitId") | ||
| Integer adUnitId; | ||
| @JsonProperty("auth") |
There was a problem hiding this comment.
No need for @JsonProperty("auth")
Comment on lines
32
to
35
| BidderDeps adverxoBidderDeps(BidderConfigurationProperties adverxoConfigurationProperties, | ||
| @NotBlank @Value("${external-url}") String externalUrl, | ||
| JacksonMapper mapper, CurrencyConversionService currencyConversionService) { | ||
|
|
There was a problem hiding this comment.
Place each parameter on new different line
| enabled: false | ||
| endpoint: https://adport.pbsadverxo.com/auction?id={{adUnitId}}&auth={{auth}} | ||
| usersync: | ||
| enabled: true |
There was a problem hiding this comment.
enabled: false for all aliases
| // given | ||
| final BidRequest bidRequest = givenBidRequest(impBuilder -> | ||
| impBuilder.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode()))) | ||
| ); |
There was a problem hiding this comment.
Place ); on previous line
| impBuilder | ||
| .bidfloor(bidFloor) | ||
| .bidfloorcur(bidFloorCur) | ||
| ); |
There was a problem hiding this comment.
Same, and look for other occurrences
CTMBNara
requested changes
Mar 10, 2025
Comment on lines
87
to
89
| final String adUnitId = String.valueOf(extImp.getAdUnitId()); | ||
| return endpointUrl | ||
| .replace(ADUNIT_MACROS_ENDPOINT, | ||
| extImp.getAdUnitId() == null ? StringUtils.EMPTY : String.valueOf(extImp.getAdUnitId())) | ||
| .replace(ADUNIT_MACROS_ENDPOINT, adUnitId == null ? "0" : adUnitId) |
There was a problem hiding this comment.
.replace(ADUNIT_MACROS_ENDPOINT, Objects.toString(extImp.getAdUnitId(), "0"))
CTMBNara
requested changes
Mar 13, 2025
Comment on lines
+50
to
+55
| public AdverxoBidder(String endpointUrl, JacksonMapper mapper, | ||
| CurrencyConversionService currencyConversionService) { | ||
| this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); | ||
| this.mapper = mapper; | ||
| this.currencyConversionService = currencyConversionService; | ||
| } |
There was a problem hiding this comment.
Last nitpick and we are good to go:
public AdverxoBidder(String endpointUrl,
JacksonMapper mapper,
CurrencyConversionService currencyConversionService) {
this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl));
this.mapper = Objects.requireNonNull(mapper);
this.currencyConversionService = Objects.requireNonNull(currencyConversionService);
}
CTMBNara
requested changes
Mar 13, 2025
Comment on lines
+7
to
+8
| @Value | ||
| @AllArgsConstructor(staticName = "of") |
Comment on lines
+12
to
+13
| Integer adUnitId; | ||
| String auth; |
There was a problem hiding this comment.
Please, add empty line between fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
#3677 (comment)