OpenX: Determine bid type based on mtype

[gmiedlar-ox]

🔧 Type of changes

• new bid adapter
• bid adapter update
• new feature
• new analytics adapter
• new module
• module update
• bugfix
• documentation
• configuration
• dependency update
• tech debt (test coverage, refactorings, etc.)

✨ What's the context?

OpenX started to return mtype field for bids in bid response, so now bid type can be determined based on this property in OpenX bidder adapter.

🧠 Rationale behind the change

We want to determine bid type based on bid mtype from bid response, to be able to process multi-format requests.

🔎 New Bid Adapter Checklist

• verify email contact works
• NO fully dynamic hostnames
• geographic host parameters are NOT required
• direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
• if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
• cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

• Are your changes following our code style guidelines?
• Are there any breaking changes in your code?
• Does your test coverage exceed 90%?
• Are there any erroneous console logs, debuggers or leftover code in your changes?

[gmiedlar-ox]

@CTMBNara could you please review this PR?

[CTMBNara]

Remove all code related to the old logic.

[gmiedlar-ox]

@CTMBNara We would like to keep the old logic and fallback to it when there is no mtype in the bid response.

[CTMBNara]

@gmiedlar-ox You can revert the commit at any time later. We don't keep "dead" code in our repository.

[gmiedlar-ox]

I don't think we have "dead" code here. In case bid.getMtype() is null or there is no case match, the "old" getBidType logic will be executed.

case null, default -> impIdToBidType.getOrDefault(bid.getImpid(), BidType.banner);