Capture and log bids rejected due to NBR 300 (Response-Rejected General) #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShriprasadM
reviewed
Jul 15, 2024
exchange/bidder_validate_bids.go
Outdated
Comment on lines
60
to
70
| if ok, err := validateBid(bid, debug); ok { | ||
| ok, err := validateBid(bid, debug) | ||
| if ok { | ||
| validBids = append(validBids, bid) | ||
| } else if err != nil { | ||
| continue | ||
| } | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| } |
There was a problem hiding this comment.
@ashishshinde-pubm : Do you see any challenges with following code snippet?
if ok, err := validateBid(bid, debug); ok {
validBids = append(validBids, bid)
} else if err != nil {
errs = append(errs, err)
seatNonBids.addBid(bid, int(ResponseRejectedGeneral), seatBid.Seat) // report seat non bid
}There was a problem hiding this comment.
@ShriprasadM when bid.Bid.Price < 0.0 , validateBid function returns ok=false and err=nil
In this case, we will miss to generate nonBid
There was a problem hiding this comment.
@ashishshinde-pubm : how do you see following
if ok, err := validateBid(bid, debug); ok {
validBids = append(validBids, bid)
} else {
seatNonBids.addBid(bid, int(ResponseRejectedGeneral), seatBid.Seat) // report seat non bid
if err != nil {
errs = append(errs, err)
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.