-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture and log bids rejected due to NBR 300 (Response-Rejected General) #3807
base: master
Are you sure you want to change the base?
Capture and log bids rejected due to NBR 300 (Response-Rejected General) #3807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishshinde-pubm : Please checkout my review comments
exchange/bidder_validate_bids.go
Outdated
if ok, err := validateBid(bid, debug); ok { | ||
ok, err := validateBid(bid, debug) | ||
if ok { | ||
validBids = append(validBids, bid) | ||
} else if err != nil { | ||
continue | ||
} | ||
if err != nil { | ||
errs = append(errs, err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishshinde-pubm : Do you see any challenges with following code snippet?
if ok, err := validateBid(bid, debug); ok {
validBids = append(validBids, bid)
} else if err != nil {
errs = append(errs, err)
seatNonBids.addBid(bid, int(ResponseRejectedGeneral), seatBid.Seat) // report seat non bid
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShriprasadM when bid.Bid.Price < 0.0
, validateBid
function returns ok=false
and err=nil
In this case, we will miss to generate nonBid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishshinde-pubm : how do you see following
if ok, err := validateBid(bid, debug); ok {
validBids = append(validBids, bid)
} else {
seatNonBids.addBid(bid, int(ResponseRejectedGeneral), seatBid.Seat) // report seat non bid
if err != nil {
errs = append(errs, err)
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.