Do not include hooks from disabled modules into execution plan #3829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #3748
How to reproduce
Here is a
pbs.yaml
config file to reproduce the problem described in the issue on the main branch:The server should be run with
Then on every request like
the server it should spit out
On the PR branch this does not happen.
Implementation Details
Disabled modules IDs are collected into the array
disabledModules
and passed down to the plan builder to be consulted when including hooks into the execution plan.