-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Oraki #3839
New Adapter: Oraki #3839
Conversation
Code coverage summaryNote:
orakiRefer here for heat map coverage report
|
@@ -0,0 +1,18 @@ | |||
endpoint: "https://eu1.oraki.io/pserver" | |||
maintainer: | |||
email: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent email for verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email verified.
@@ -0,0 +1,18 @@ | |||
endpoint: "https://eu1.oraki.io/pserver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint is reachable.
Hi @BenOraki, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Copper6SSP adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter. Please let us know your thoughts on whether this is a possibility for you. |
Hi @bsardo, we do not share the same server with any of the adapters you mentioned. So we cannot use aliases. This pull request is very time-sensitive, and we must get it out as soon as possible. However, I will consider some methods of code duplication reduction in the future for our adapter. |
- video | ||
- native | ||
userSync: | ||
redirect: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usersync works!
https://sync.oraki.io/pbserver?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&redir=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Doraki%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%5BUID%5D
@gargcreation1992 I see that this PR has been approved. Can it be merged now? |
Hi @BenOraki, we just got a second approval so your PR is ready to merge. I'm holding off on doing so at the moment until I fix a critical issue with the latest release and then we will merge this in. |
Hi @bsardo, why wasn’t this PR included in the last release? |
@BenOraki we had a freeze on merging PRs for the last release due to the critical issue mentioned earlier. This is being merged now and will be part of v2.29.0. |
DOC
prebid/prebid.github.io#5403