Kargo: Add iframe sync option #3855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,9 @@ capabilities: | |||
| - video | |||
| - native | |||
| userSync: | |||
| iframe: | |||
| url: "https://crb.kargo.com/api/v1/initsyncpbs?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&r={{.RedirectURL}}" | |||
| userMacro: "$UID" | |||
There was a problem hiding this comment.
The user sync url is not setting UID for the following URL. Please check -
https://crb.kargo.com/api/v1/initsyncpbs?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&r=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dkargo%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24UID
There was a problem hiding this comment.
Same is happening for me
There was a problem hiding this comment.
If youve only called once it wont work until we've had a chance to place a cookie. Refresh and you should see it. Implementing a loop-redirect to place a cookie on the first attempt is in the backlog.
I'm addressing that extra \n now but that shouldnt cause any issues.
There was a problem hiding this comment.
Please raise this PR once you have implemented a loop-redirect to place a cookie on the first attempt. We should be able to merge it when that is resolved.
bsardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds iframe sync option to kargo.yaml.
This endpoint will append the specified
r(RedirectURL) to the list of returned pixels in the iframe. Aside from the appended redirecturl, this list of pixels are the same as from Kargo's prebid js adapter.Test url here:
https://crb.kargo.com/api/v1/initsyncpbs?r=https%3A%2F%2Fwww.kargo.com%3Fuid%3D%24UID