Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make interpolation after crash optional #113

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Make interpolation after crash optional #113

merged 11 commits into from
Jul 11, 2024

Conversation

tjwsch
Copy link
Collaborator

@tjwsch tjwsch commented Jun 12, 2024 •
edited
Loading

This PR makes the interpolation of crashed micro simulations optional. With this sklearn becomes an optional dependency.
Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@tjwsch tjwsch added the enhancement Enchance existing functionality label Jun 12, 2024
@tjwsch tjwsch marked this pull request as ready for review June 12, 2024 10:11
IshaanDesai
IshaanDesai reviewed Jul 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai reviewed Jul 11, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai reviewed Jul 11, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai reviewed Jul 11, 2024
View reviewed changes
docs/installation.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai reviewed Jul 11, 2024
View reviewed changes
docs/running.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments from my side. Rest looks good 👍 please directly merge once the comments are incorporated.

@tjwsch tjwsch merged commit 6fafea2 into develop Jul 11, 2024
10 checks passed
@tjwsch tjwsch deleted the add_optional_dependencies branch July 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees
No one assigned
Labels
enhancement Enchance existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjwsch @IshaanDesai