-
-
Notifications
You must be signed in to change notification settings - Fork 74
Generic hf properties #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added support for new downsamplable properties: `marker_symbol` and `hf_marker_symbol`. - Refactored the handling of high-frequency properties to be more dynamic and extensible. - Updated the `_hf_data_container` to include new properties and adjusted parsing logic accordingly. - Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 83.83% 88.11% +4.28%
==========================================
Files 13 14 +1
Lines 1206 1245 +39
==========================================
+ Hits 1011 1097 +86
+ Misses 195 148 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll extend the code and tests as well to fix #320 |
|
Ready for review @jvdd! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Much more readable now :)
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
…resampler into feat/hf_properties
…resampler into feat/hf_properties
Aims to provide a more generic interface for passing
hf_propsRelated #354
Added support for new downsamplable properties:
marker_symbolandhf_marker_symbol.Refactored the handling of high-frequency properties to be more dynamic and extensible.
Updated the
_hf_data_containerto include new properties and adjusted parsing logic accordingly.Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.
updated
ruffto improve and homogenize linting experience in CI-CD