Skip to content

Conversation

@jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Aug 20, 2025

Aims to provide a more generic interface for passing hf_props

Related #354

  • Added support for new downsamplable properties: marker_symbol and hf_marker_symbol.

  • Refactored the handling of high-frequency properties to be more dynamic and extensible.

  • Updated the _hf_data_container to include new properties and adjusted parsing logic accordingly.

  • Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.

  • updated ruff to improve and homogenize linting experience in CI-CD

- Added support for new downsamplable properties: `marker_symbol` and `hf_marker_symbol`.
- Refactored the handling of high-frequency properties to be more dynamic and extensible.
- Updated the `_hf_data_container` to include new properties and adjusted parsing logic accordingly.
- Introduced tests to validate the functionality of dynamic properties and their priority over trace attributes.
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.11%. Comparing base (560e6b9) to head (a4d5287).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ler/figure_resampler/figure_resampler_interface.py 60.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   83.83%   88.11%   +4.28%     
==========================================
  Files          13       14       +1     
  Lines        1206     1245      +39     
==========================================
+ Hits         1011     1097      +86     
+ Misses        195      148      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonasvdd
Copy link
Member Author

jonasvdd commented Aug 21, 2025

I'll extend the code and tests as well to fix #320

@jonasvdd
Copy link
Member Author

Ready for review @jvdd!

@jonasvdd jonasvdd requested a review from jvdd August 22, 2025 09:17
@jonasvdd jonasvdd added the enhancement New feature or request label Aug 22, 2025
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much more readable now :)

@jonasvdd jonasvdd merged commit 9483326 into main Sep 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants