Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use Zip instead of manual for loop #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Apr 25, 2023

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2023

CodSpeed Performance Report

Merging #47 optimize_mmlttb (0e1c696) will degrade performances by 14.11%.

Summary

🔥 3 improvements
❌ 2 regressions
✅ 385 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main optimize_mmlttb Change
🔥 test_minmaxlttb_with_x[True-float64-100-100,000] 24 ms 16.6 ms +44.01%
🔥 test_m4_with_x[True-int32-1,000-100,000] 8.1 ms 6.4 ms +25.7%
🔥 test_minmaxlttb_with_x[True-int64-100-100,000] 39.4 ms 17.2 ms ×2.3
test_m4_with_x[True-int64-1,000-1,000,000] 14.1 ms 15.7 ms -10.37%
test_minmaxlttb_no_x[True-int32-1,000-100,000] 13.8 ms 16.1 ms -14.11%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant