Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
minmax_ratio
to 4 (was previously 30) - this change is based on the empirical evidence gathered in our research on the MinMaxLTTB work; https://arxiv.org/abs/2305.00332 (in this paperminmax_ratio
is called the "preselection ratio").Note that in plotly-resasampler we already used 4 as default value (in the wrapper for this package);
https://github.com/predict-idlab/plotly-resampler/blob/741da5d2358bee59c59d1591b0722ab0ea66bbb6/plotly_resampler/aggregation/aggregators.py#L211
This PR also fixes a minor bug when calling
MinMaxLTTB.downsample
(without an x array) -> the indices of the preselected data points should be passed to the LTTB algorithm (2nd step of the algorithm) in order to have a more correct triangle surface calculation (-> will resemble more closesly vanilla LTTB behavior).Credits are due to @raphaelvallat for uncovering this issue