Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213
This pull request updates the image build workflow to better handle multi-platform builds by distinguishing between platforms that are actively built and those that are only included as variants in the published manifest. The main change is the introduction of a
platforms_to_buildparameter, allowing the Dagger app to search for multi-arch manifests in the registry, with the same image tag, and include those already uploaded images to the manifest.Multi-platform build and publish improvements:
compile_image_and_publishinbuild_images.pyto accept bothplatforms_to_build(platforms to actually build) andplatforms(all platforms to include in the manifest). Platforms not built are logged and added as variants using the existing image, with error handling if a variant cannot be created.compile_image_and_publishincompile_images_for_all_flavorsto pass bothplatforms_to_buildandplatformsas arguments, ensuring the new logic is used throughout the workflow.Testing updates:
test_build_images_functionality.pyto use the newplatforms_to_buildparameter and ensure the test covers the new function signature and logic. [1] [2]Minor cleanup:
loginmethod for code tidiness.