Remove private dns zone on azure vnet and subnet tfm module

[alambike]

No description provided.

[Copilot]

Pull request overview

This PR removes Private DNS Zone creation/linking functionality from the azure-vnet-and-subnet Terraform module, simplifying the module to only manage VNets, subnets, and VNet peerings.

Changes:

• Removes the private_dns_zones input variable from the module.
• Deletes the azurerm_private_dns_zone and azurerm_private_dns_zone_virtual_network_link resources.
• Removes the related outputs and partial README references.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
modules/azure-vnet-and-subnet/variables.tf	Removes private_dns_zones input, but currently leaves peerings/tags definitions in a broken state.
modules/azure-vnet-and-subnet/private_dns_zone.tf	Deletes Private DNS Zone resource creation.
modules/azure-vnet-and-subnet/private_dns_zone_vnet_link.tf	Deletes Private DNS Zone ↔ VNet link resource creation logic.
modules/azure-vnet-and-subnet/outputs.tf	Removes private DNS-related outputs.
modules/azure-vnet-and-subnet/README.md	Removes some private DNS references, but still contains stale examples/outputs further down.

Comments suppressed due to low confidence (2)

modules/azure-vnet-and-subnet/variables.tf:28

• variables.tf is now syntactically invalid: the peerings variable’s type = list(object({ ... block is not closed, and the subsequent tags variable fields appear to be accidentally inlined inside peerings (the variable "tags" { header and the remaining peerings attributes are missing). This will prevent terraform init/validate from running. Restore a complete peerings object schema (matching the fields used in vnet-peering.tf) and reintroduce a separate variable "tags" block.

  description = "List of virtual network peerings"
  type = list(object({
    peering_name                 = string
    allow_forwarded_traffic      = optional(bool, false)
  description = "The tags to associate with your resources"

modules/azure-vnet-and-subnet/README.md:56

• The README removes private_dns_zones from the Inputs table, but later sections still document and show usage/output for private_dns_zones, private_dns_zone_ids, and private_dns_zone_virtual_network_link_ids (see the .tfvars example and Output snippet further down). Please update/remove those examples and output docs so the README matches the module after dropping private DNS zone support.

| `peerings` | List of virtual network peerings | list(object) | `[]` | no |
| `peerings.peering_name` | The name of the peering | string | n/a | yes |
| `peerings.allow_forwarded_traffic` | Whether forwarded traffic is allowed | bool | `false` | no |
| `peerings.allow_gateway_transit` | Whether gateway transit is allowed | bool | `false` | no |
| `peerings.allow_virtual_network_access` | Whether virtual network access is allowed | bool | `true` | no |

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gustavoborragan]

Desestimada