Skip to content

chore(aws-backup): added first release#950

Open
kastras wants to merge 29 commits intomainfrom
add/aws_backup
Open

chore(aws-backup): added first release#950
kastras wants to merge 29 commits intomainfrom
add/aws_backup

Conversation

@kastras
Copy link
Contributor

@kastras kastras commented Feb 27, 2026

No description provided.

@kastras kastras self-assigned this Feb 27, 2026
@kastras kastras requested a review from a team as a code owner February 27, 2026 12:34
@kastras kastras requested a review from Copilot February 27, 2026 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the first release of a new AWS Backup Terraform module to the repository. The module provides configuration for AWS Backup services, including vault creation, backup plans with scheduling, resource selection via tags or ARNs, cross-account/cross-region replication, and IAM role management.

Changes:

  • Added new aws-backup module with infrastructure code for managing AWS Backup vaults, plans, and selections
  • Configured release-please for the new module with initial version 0.0.0
  • Included comprehensive documentation with examples for minimal, plan-based, and replication scenarios

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 28 comments.

Show a summary per file
File Description
release-please-config.json Added aws-backup module configuration for release management
.release-please-manifest.json Registered aws-backup module with initial version 0.0.0
modules/aws-backup/versions.tf Terraform and AWS provider version constraints
modules/aws-backup/variables.tf Variable definitions for vault, plan, selection, and copy action configuration
modules/aws-backup/main.tf Core resources: backup vaults, plans, and selections (tag-based and ARN-based)
modules/aws-backup/iam-policy-roles.tf IAM roles, policies, and vault access policies for backup operations
modules/aws-backup/backup-global-configuration.tf Optional global settings for cross-account backup enablement
modules/aws-backup/docs/header.md Module overview, features, usage examples, and file structure documentation
modules/aws-backup/docs/footer.md Additional examples and external resource links
modules/aws-backup/README.md Auto-generated comprehensive module documentation
modules/aws-backup/.terraform-docs.yml Configuration for terraform-docs automated documentation generation
modules/aws-backup/_examples/minimal/main.tf Example showing minimal vault creation without backup plans
modules/aws-backup/_examples/vault_with_plan_and_selection/main.tf Example with backup plan and tag-based resource selection
modules/aws-backup/_examples/vault_with_plan_selection_with_replication/main.tf Example demonstrating cross-region backup replication

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kastras and others added 17 commits February 27, 2026 13:54
…n.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…plication/main.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…plication/main.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +67 to +87
For the accounts in your organization

In the account that only receive backups:

```hcl
module "backup" {
source = "github.com/prefapp/tfm/modules/aws-backup"
aws_backup_vault = [{
vault_name = "only-rds-component-tags-backup"
# vault_region = "eu-west-1"
# vault_tags = {
# "one" = "two"
# "tree" = "four"
# }
}
]
}
```

In the account that you will made backups and sending to other account

Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issues in the documentation: “In the account that only receive backups” and “you will made backups” are incorrect. Please adjust these sentences (e.g., “only receives backups” / “you will make backups…”) to improve clarity for module consumers.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 27, 2026

@kastras I've opened a new pull request, #951, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* fix(aws-backup): correct grammar and typos in documentation

Co-authored-by: kastras <46498851+kastras@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kastras <46498851+kastras@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Mar 2, 2026

@kastras I've opened a new pull request, #956, to work on those changes. Once the pull request is ready, I'll request review from you.

kastras and others added 4 commits March 2, 2026 09:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Mar 6, 2026

@kastras I've opened a new pull request, #963, to work on those changes. Once the pull request is ready, I'll request review from you.

@kastras kastras requested a review from Copilot March 11, 2026 13:53
@kastras
Copy link
Contributor Author

kastras commented Mar 11, 2026

@kastras I've opened a new pull request, #963, to work on those changes. Once the pull request is ready, I'll request review from you.

I closed it becouse does not had modified files.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants