Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the first release of a new AWS Backup Terraform module to the repository. The module provides configuration for AWS Backup services, including vault creation, backup plans with scheduling, resource selection via tags or ARNs, cross-account/cross-region replication, and IAM role management.
Changes:
- Added new aws-backup module with infrastructure code for managing AWS Backup vaults, plans, and selections
- Configured release-please for the new module with initial version 0.0.0
- Included comprehensive documentation with examples for minimal, plan-based, and replication scenarios
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 28 comments.
Show a summary per file
| File | Description |
|---|---|
| release-please-config.json | Added aws-backup module configuration for release management |
| .release-please-manifest.json | Registered aws-backup module with initial version 0.0.0 |
| modules/aws-backup/versions.tf | Terraform and AWS provider version constraints |
| modules/aws-backup/variables.tf | Variable definitions for vault, plan, selection, and copy action configuration |
| modules/aws-backup/main.tf | Core resources: backup vaults, plans, and selections (tag-based and ARN-based) |
| modules/aws-backup/iam-policy-roles.tf | IAM roles, policies, and vault access policies for backup operations |
| modules/aws-backup/backup-global-configuration.tf | Optional global settings for cross-account backup enablement |
| modules/aws-backup/docs/header.md | Module overview, features, usage examples, and file structure documentation |
| modules/aws-backup/docs/footer.md | Additional examples and external resource links |
| modules/aws-backup/README.md | Auto-generated comprehensive module documentation |
| modules/aws-backup/.terraform-docs.yml | Configuration for terraform-docs automated documentation generation |
| modules/aws-backup/_examples/minimal/main.tf | Example showing minimal vault creation without backup plans |
| modules/aws-backup/_examples/vault_with_plan_and_selection/main.tf | Example with backup plan and tag-based resource selection |
| modules/aws-backup/_examples/vault_with_plan_selection_with_replication/main.tf | Example demonstrating cross-region backup replication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/aws-backup/_examples/vault_with_plan_and_selection/main.tf
Outdated
Show resolved
Hide resolved
modules/aws-backup/_examples/vault_with_plan_and_selection/main.tf
Outdated
Show resolved
Hide resolved
…n.tf Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.tf Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…plication/main.tf Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…plication/main.tf Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…add/aws_backup
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| For the accounts in your organization | ||
|
|
||
| In the account that only receive backups: | ||
|
|
||
| ```hcl | ||
| module "backup" { | ||
| source = "github.com/prefapp/tfm/modules/aws-backup" | ||
| aws_backup_vault = [{ | ||
| vault_name = "only-rds-component-tags-backup" | ||
| # vault_region = "eu-west-1" | ||
| # vault_tags = { | ||
| # "one" = "two" | ||
| # "tree" = "four" | ||
| # } | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| In the account that you will made backups and sending to other account | ||
|
|
There was a problem hiding this comment.
Grammar issues in the documentation: “In the account that only receive backups” and “you will made backups” are incorrect. Please adjust these sentences (e.g., “only receives backups” / “you will make backups…”) to improve clarity for module consumers.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Initial plan * fix(aws-backup): correct grammar and typos in documentation Co-authored-by: kastras <46498851+kastras@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kastras <46498851+kastras@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.