fix: if a spec is source, don't merge but force the source #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruben-arts not sure what's happening here but do we need to "merge" any specs at all? Or is this when there is a source spec and another spec at the same time (in which case we should ignore everything except the source one?). |
nichmor
reviewed
Oct 9, 2025
| assert "contains spaces" in str(exc) | ||
|
|
||
|
|
||
| def test_specs_with_none(): |
There was a problem hiding this comment.
can we maybe add a test with source usecase?
…s_on_merge # Conflicts: # backends/pixi-build-ros/pixi.lock
|
This is failing due to not having the latest |
nichmor
approved these changes
Oct 14, 2025
| "py_rattler", | ||
| "py-pixi-build-backend", | ||
| # TODO: publish to pypi | ||
| # "py-pixi-build-backend", |
There was a problem hiding this comment.
I wonder if it should be also lowercase like py_rattler?
There was a problem hiding this comment.
the conda-forge maintainers asked me to use -s
Hofer-Julian
pushed a commit
to Hofer-Julian/pixi-build-backends
that referenced
this pull request
Oct 14, 2025
Hofer-Julian
pushed a commit
to Hofer-Julian/pixi-build-backends
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
Tested with the example in https://github.com/noahjutz/robostack-build-local-package-issue-minimal/tree/main, thanks @noahjutz for this!
We just took the
binary_specbut if it's source, that will property returnsNone, resulting in the error from the issue. This change deals with that by forcing a dependency from source to be only from source, skipping the merge code.If in the future this code would be reached, we now do type checking to avoid this strange error.