feat: ros backend tests #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
2510560 to
28ef57b
Compare
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
b07681f to
e504199
Compare
ruben-arts
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
The ROS specificness of this PR looks good to me! @Hofer-Julian could you validate that the testing logic and repo changes are proper?
scripts/download-artifacts.py
Outdated
Comment on lines
154
to
165
| repodata_files = sorted( | ||
| list(temp_dir.rglob("repodata.json")) | ||
| + list(temp_dir.rglob("repodata.json.zst")) | ||
| ) | ||
|
|
||
| console.print(f"[blue]Found {len(backend_executables)} backend executable(s)") | ||
|
|
||
| # Extract all executables | ||
| for executable in backend_executables: | ||
| final_path = output_dir / Path(executable).name | ||
| if final_path.exists(): | ||
| if final_path.is_dir(): | ||
| shutil.rmtree(final_path) | ||
| else: | ||
| final_path.unlink() | ||
| if not repodata_files: | ||
| raise FileNotFoundError( | ||
| "Could not locate a channel directory inside the artifact. " | ||
| f"Archive contents: {file_list}" | ||
| ) | ||
|
|
||
| zip_ref.extract(executable, output_dir) | ||
| extracted_path = output_dir / executable | ||
| channel_dir = repodata_files[0].parent.parent |
There was a problem hiding this comment.
I don't understand this code :)))))
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
dd776fd to
34e1675
Compare
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
34e1675 to
55d8243
Compare
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
11be9fb to
559bcb6
Compare
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
6c8aa6d to
b548c83
Compare
This reverts commit 234f61f.
remimimimimi
force-pushed
the
feat/ros-backend-tests
branch
from
bb98e05 to
1544854
Compare
Comment on lines
+111
to
+113
| if channel_source.exists(): | ||
| print("🧹 Removing existing channel directory before rebuilding") | ||
| shutil.rmtree(channel_source) |
| is_windows = sys.platform.startswith("win") | ||
|
|
||
| # Find the pixi binary | ||
| some_repodata_file = None |
There was a problem hiding this comment.
Let's rename this to is_channel
Comment on lines
+33
to
+35
| env_override = os.environ.get("PIXI_TESTSUITE_BACKEND_CHANNEL") | ||
| if env_override: | ||
| return env_override |
There was a problem hiding this comment.
Let's remove this env var everywhere
| if channel_dir.is_dir() and any(channel_dir.rglob("repodata.json")): | ||
| return channel_dir.as_uri() | ||
|
|
||
| return None |
There was a problem hiding this comment.
Raise exception instead
Comment on lines
+59
to
+60
| if local_uri is None: | ||
| return copied_str |
There was a problem hiding this comment.
Suggested change
| if local_uri is None: | |
| return copied_str |
Comment on lines
+74
to
+77
| try: | ||
| data = tomllib.loads(updated) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Don't catch exception
| return None | ||
|
|
||
|
|
||
| def copy_manifest( |
There was a problem hiding this comment.
Please add doc comments
| src: str | os.PathLike[str], | ||
| dst: str | os.PathLike[str], | ||
| *, | ||
| follow_symlinks: bool = True, |
There was a problem hiding this comment.
Let's try to remove this
| return copied_str | ||
|
|
||
|
|
||
| def copytree_with_local_backend( |
There was a problem hiding this comment.
I think it would be nice to also do this within this function:
# Remove existing .pixi folders
shutil.rmtree(cmake_env_test_project.joinpath(".pixi"), ignore_errors=True)
Afterwards we can remove this rmtree call everywhere
| def simple_workspace( | ||
| tmp_pixi_workspace: Path, | ||
| request: pytest.FixtureRequest, | ||
| local_backend_channel_uri: str | None, |
There was a problem hiding this comment.
Suggested change
| local_backend_channel_uri: str | None, | |
| local_backend_channel_uri: str, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests on top of https://github.com/ruben-arts/ros_workspace/ that packages are being built, extra-input-globs are stored in
metadata.jsonfile and that file change triggers rebuild.Cross-dependent on prefix-dev/pixi-build-backends#395.