-
Notifications
You must be signed in to change notification settings - Fork 384
fix: Propagate target-platform flags for pixi build #4703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm still testing to make sure this works the way I expect but wanted to open the PR to start the conversation and get feedback. |
|
@ruben-arts I was able to test this locally and confirm it solves the cross compilation issue I was seeing with multiple source packages in a workspace. What else do you need from me to get this merged? |
|
Thank you @AdamDorwart! This code is mostly untouched by me, @baszalmstra would you know a way we could confidently write a test for this? |
|
I dont understand, the changes seem to be completely unrelated to the description? Did you accidentally override the changes? |
|
@baszalmstra my apologies some unrelated changes were merged to this same branch. I will fix this up shortly. Only the first commit with the one line change was intended for this PR. |
|
Ah that makes sense! Your first commit looks good indeed! If you remove the other changes we can merge. |
339da7d to
0f912c0
Compare
|
@baszalmstra Sorry again for that confusion. Should be good to go now. |
|
No worries! Thanks for the contribution! |
During some experimentation with
pixi build --target-platform <target>I noticed if I had multiple packages in a workspace with dependencies they would build fine with justpixi buildbut adding--target-platformwould fail. If it was just a single independent package it worked fine but the dependencies would report as not existing for the target platform.After a bit of digging I discovered this fix would propagate the target platform correctly so that transitive dependencies would build for my target platform.