fix: Propagate target-platform flags for pixi build #4703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamDorwart
changed the title
|
I'm still testing to make sure this works the way I expect but wanted to open the PR to start the conversation and get feedback. |
|
@ruben-arts I was able to test this locally and confirm it solves the cross compilation issue I was seeing with multiple source packages in a workspace. What else do you need from me to get this merged? |
|
Thank you @AdamDorwart! This code is mostly untouched by me, @baszalmstra would you know a way we could confidently write a test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some experimentation with
pixi build --target-platform <target>I noticed if I had multiple packages in a workspace with dependencies they would build fine with justpixi buildbut adding--target-platformwould fail. If it was just a single independent package it worked fine but the dependencies would report as not existing for the target platform.After a bit of digging I discovered this fix would propagate the target platform correctly so that transitive dependencies would build for my target platform.