Skip to content

feat(add): --channel parameter to specify channel. #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prady0t wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(add): --channel parameter to specify channel. #4987

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
96b27f2
Add --channel argument to specify channel.
prady0t Nov 27, 2025
fa8324a
addresing test failure
prady0t Nov 27, 2025
0f07dce
Only accounting for --channel if input is specified
prady0t Nov 28, 2025
e25c18b
linter errors
prady0t Nov 28, 2025
0d6e0c5
adding info to docs
prady0t Nov 28, 2025
ae9e562
Merge branch 'main' into add-channel-parameter
prady0t Nov 28, 2025
cc9d79e
Adding support of channel in MatchSpec
prady0t Dec 3, 2025
98fbf8d
Merge branch 'add-channel-parameter' of https://github.com/prady0t/pi…
prady0t Dec 3, 2025
55e0ffe
Merge branch 'main' into add-channel-parameter
prady0t Dec 3, 2025
9ee7e8f
Moving the code to pixi_api
prady0t Dec 4, 2025
ec4b2af
Merge branch 'main' into add-channel-parameter
baszalmstra Dec 5, 2025
74becfc
Use NamedChannelOrUrl instead of Channel
prady0t Dec 7, 2025
c033916
Removing redundent tests
prady0t Dec 7, 2025
b130eaa
Removing redundent tests
prady0t Dec 7, 2025
2f0e72a
Removing redundent tests
prady0t Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/pixi_cli/src/add.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ use indexmap::IndexMap;
use miette::IntoDiagnostic;
use pixi_config::ConfigCli;
use pixi_core::{WorkspaceLocator, environment::sanity_check_workspace, workspace::DependencyType};
use pixi_manifest::{FeatureName, KnownPreviewFeature, SpecType};
use pixi_manifest::{FeatureName, KnownPreviewFeature, SpecType, PrioritizedChannel};
use pixi_spec::{GitSpec, SourceLocationSpec, SourceSpec};
use rattler_conda_types::{MatchSpec, PackageName};
use rattler_conda_types::{MatchSpec, PackageName, NamedChannelOrUrl};

use crate::{
cli_config::{DependencyConfig, LockFileUpdateConfig, NoInstallConfig, WorkspaceConfig},
Expand Down Expand Up @@ -92,6 +92,11 @@ pub struct Args {
/// Whether the pypi requirement should be editable
#[arg(long, requires = "pypi")]
pub editable: bool,

// Specify channel
#[arg(long)]
pub channel: Option<String>,

}

pub async fn execute(args: Args) -> miette::Result<()> {
Expand All @@ -111,6 +116,10 @@ pub async fn execute(args: Args) -> miette::Result<()> {

let mut workspace = workspace.modify()?;

// Add a channel
let channel = args.channel;
workspace.manifest().add_channels([PrioritizedChannel::from(NamedChannelOrUrl::Name(String::from(channel.unwrap_or_default()))).clone()], &FeatureName::DEFAULT, false)?;
Copy link
Contributor Author

@prady0t prady0t Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line just calls the add_channels() function with the args given from the user, so testing this is essentially testing the functionalities of add_channel() which is already tested and also includes the situation where we try to add channel when it's already present.

@baszalmstra Do you think we sould still try to add tests for this? If so could me point to where the tests for cli inputs are(or should be) present.


// Add the platform if it is not already present
workspace
.manifest()
Expand Down
Loading