-
Notifications
You must be signed in to change notification settings - Fork 401
feat: Support PEP508 environment markers #5241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support PEP508 environment markers #5241
Conversation
781704a to
c840936
Compare
c840936 to
684c3da
Compare
734fa83 to
0abb254
Compare
tdejager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work seems easier then expected! Can you test if satisfiability works as expected, i.e changing markers re-solves and such? Also test if adding a linux marker with windows as a platform for example creates an empty dependency set. Maybe there are more edge cases we could test and report on?
|
Maybe we should also have some documentation updates, not sure, could you have a look? |
688bc09 to
1737ae2
Compare
1737ae2 to
2bb2372
Compare
f3004e7 to
d2e632f
Compare
Done in 06329e3 |
|
@tdejager @baszalmstra I think this is ready, review/merge appreciated. |
|
I looked through everything and all of it makes sense! Let me do a small user-test myself. |
Description
Fixes #1259
How Has This Been Tested?
Checklist:
schema/model.py.