You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No existing behavior should be changed, only functionality has been added.
Anything else we should know?
There are 2 ways of enabeling this new feature, either by an empty string "", or by specifying a custom dirrectory. the projectName will automaticcaly be appended to this path with the xml extension added.
when an empty string is entered the resulting filepath will be made consisting of the targetDir and the projectName with the xml extension appended to it.
this is the preffered method because visualstudio can by default only recognize when dll and xmlDocumentationFile are in the sam folder.
hacky ways that wher used before this feature solution to 359 'closed' Did you check all the boxes?
Focus on a single fix or feature; remove any unrelated formatting or code changes
Add unit tests showing fix or feature works; all tests pass
Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
Please go through and clean up the documentation file. Unnecessary capitalization, spacing around slashes, some wording that's uncomfortable to read. I'm happy with the code, just want the docs to be a bit better.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #359
What does this PR do?
this PR makes it possible to enable the xmlDocumentationFile in visualStudio C# projects.
vs
How does this PR change Premake's behavior?
No existing behavior should be changed, only functionality has been added.
Anything else we should know?
There are 2 ways of enabeling this new feature, either by an empty string "", or by specifying a custom dirrectory. the projectName will automaticcaly be appended to this path with the xml extension added.
when an empty string is entered the resulting filepath will be made consisting of the targetDir and the projectName with the xml extension appended to it.
this is the preffered method because visualstudio can by default only recognize when dll and xmlDocumentationFile are in the sam folder.
hacky ways that wher used before this feature
solution to 359 'closed'
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!