Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for VimuxTogglePane, check for valid shell on _VimuxNearestIndex(), others #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pantosaur
Copy link

@pantosaur pantosaur commented Sep 25, 2019

  • the VimuxTogglePane function was not working properly, e.g. -s and -t flags were interchanged.

  • Changed _VimuxNearestIndex to make sure vimux does not use a pane hosting a pts for which the process running is not in the list g:VimuxShells, (default ["bash","zsh"]). This makes sure we don't send random keys to a random program open in the nearest pane. If the runner type is "window", a pane will only be valid if it is the only pane of the window, and the window is not the same as the one of the vim program.

  • g:VimuxRunnerIndex is changed to a list that looks like [window,pane] and functions that take the runner index are given the joined string, which works in all cases regardless of "window" or "pane" runner type.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to prepare this contribution. It looks to me like some of these issue have been since addressed other ways, and certainly the code based has changed enough that it introduces conflicts for other reasons too. There may still be some of this that is useful though, but I'm having trouble putting my finger on what. Any chance you are around to look into it and clarify/rebase as needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants