Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running command in existing tmux pane #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominikduda
Copy link

No description provided.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic change dosen't look right. I don't have time to dig into why the test was there, but removing the check for whether the thing we think should exist actually does does not feel right. There may be a bug here in some other way. Perhaps we need to first check the opposite condition: that the runner index is set and still exists, then the else statement would be to open a new runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants