Prevent errors when runner is closed by something other than vimux #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #236, if the runner was already manually closed when we call
VimuxCloseRunner
we get the following error:This is an annoyance for people who use
VimuxCloseOnExit
. The error could spread to other commands as well, since the error prevents vimux from unsettingVimuxRunnerIndex
, leading other commands to believe the runner is still available.The error can occur in other contexts too, as seen in #229.
We generally only check if the
VimuxRunnerIndex
variable is defined before attempting to interact with the runner. This variable is only unset if vimux closes the runner, so any time anything else loses the runner we will get errors.We have some options:
I think for now I'll just enhance the checks we already have to make sure that the runner actually exists, rather than just checking for the index variable's existence.