Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected version reported when running 'goose up' in the no change case #532

Closed
jonseymour opened this issue Jun 10, 2023 · 1 comment · Fixed by #533
Closed

unexpected version reported when running 'goose up' in the no change case #532

jonseymour opened this issue Jun 10, 2023 · 1 comment · Fixed by #533

Comments

@jonseymour
Copy link

description

Currently, when goose runs up in the fully applied state, it reports 0 as the current version rather than the actual current version. This is not expected.

actual output

platform/main@local >goose down
2023/06/10 13:32:48 OK   00297_initial_warehouse_version.sql (10.3ms)
platform/main@local >goose up
2023/06/10 13:32:50 OK   00297_initial_warehouse_version.sql (13.48ms)
2023/06/10 13:32:50 goose: no migrations to run. current version: 297
platform/main@local >goose version
2023/06/10 13:33:04 goose: version 297
platform/main@local >goose up
2023/06/10 13:33:06 goose: no migrations to run. current version: 0

expected output

platform/main@local >goose down
2023/06/10 13:32:48 OK   00297_initial_warehouse_version.sql (10.3ms)
platform/main@local >goose up
2023/06/10 13:32:50 OK   00297_initial_warehouse_version.sql (13.48ms)
2023/06/10 13:32:50 goose: no migrations to run. current version: 297
platform/main@local >goose version
2023/06/10 13:33:04 goose: version 297
platform/main@local >goose up
2023/06/10 13:33:06 goose: no migrations to run. current version: 297

goose version

goose version:v3.11.2-1-upowr-g3d345c4

e.g. (our local build of the current master version of goose)

@jonseymour jonseymour changed the title unexpected version up in no change caase unexpected version up in no change case Jun 10, 2023
@jonseymour jonseymour changed the title unexpected version up in no change case unexpected version when running 'goose up' in the no change case Jun 10, 2023
@jonseymour jonseymour changed the title unexpected version when running 'goose up' in the no change case unexpected version reported when running 'goose up' in the no change case Jun 10, 2023
@mfridman
Copy link
Collaborator

mfridman commented Jun 10, 2023

Thanks for the report, fixed in #533. Just needed to remove a check on that log line, doesn't affect migrations themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants