Fix current version in empty up state #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
commented
Jun 10, 2023
goose_test.go
Outdated
| output string | ||
| }{ | ||
| {"up", true, ""}, | ||
| {"up", false, "goose: no migrations to run. current version: 3"}, |
There was a problem hiding this comment.
This test covers the wrong version in the print line. It's also intended to be an improved way to write these kinds of tests. We'll likely want to add "golden files" to capture the output.
Note, the binary is built once and reused so future tests can just call runGoose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #532
For
upcases when there are no versions to apply (such as when you runupmultiple times in a row), we need to lookup the current version.