Forward compatibility with dbplyr 2.5.0 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't _think_ there should be any other problems, but if you could run your tests with dev dbplyr installed, I'd certainly appreciate it.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 34.30% 34.27% -0.04%
==========================================
Files 46 46
Lines 1775 1777 +2
==========================================
Hits 609 609
- Misses 1166 1168 +2 ☔ View full report in Codecov by Sentry. |
jarodmeng
reviewed
Feb 22, 2024
| @@ -15,7 +15,9 @@ get_tables_from_sql.lazy_select_query <- function(query) { | |||
|
|
|||
| #' @export | |||
| get_tables_from_sql.lazy_base_remote_query <- function(query) { | |||
| if (inherits(query$x, "dbplyr_table_ident")) { | |||
| if (inherits(query$x, "dbplyr_table_path")) { # dbplyr >= 2.5.0 | |||
| utils::getFromNamespace("table_path_name", "dbplyr")(query$x) | |||
There was a problem hiding this comment.
@hadley table_path_name() seems to be exported from dbplyr 2.5.0. Should we just use dbplyr::table_path_name() instead?
There was a problem hiding this comment.
You can, but it will cause a R CMD check WARNING If you submit to CRAN before dbplyr 2.5.0 is released.
There was a problem hiding this comment.
Got it. I will merge this in first and modify the function call when dbplyr 2.5.0 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there should be any other problems, but if you could run your tests with dev dbplyr installed, I'd certainly appreciate it.