Skip to content

feat: Add TW feature flag for Report Builder Remote UDF #26472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add TW feature flag for Report Builder Remote UDF #26472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions presto-native-execution/presto_cpp/main/common/Configs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ SystemConfig::SystemConfig() {
NUM_PROP(kLargestSizeClassPages, 256),
BOOL_PROP(kEnableVeloxTaskLogging, false),
BOOL_PROP(kEnableVeloxExprSetLogging, false),
BOOL_PROP(kEnableFbRemoteReportBuilderFunction, true),
NUM_PROP(kLocalShuffleMaxPartitionBytes, 268435456),
STR_PROP(kShuffleName, ""),
STR_PROP(kRemoteFunctionServerCatalogName, ""),
Expand Down Expand Up @@ -658,6 +659,10 @@ bool SystemConfig::enableVeloxExprSetLogging() const {
return optionalProperty<bool>(kEnableVeloxExprSetLogging).value();
}

bool SystemConfig::enableFbRemoteReportBuilderFunction() const {
return optionalProperty<bool>(kEnableFbRemoteReportBuilderFunction).value();
}

bool SystemConfig::useMmapAllocator() const {
return optionalProperty<bool>(kUseMmapAllocator).value();
}
Expand Down
4 changes: 4 additions & 0 deletions presto-native-execution/presto_cpp/main/common/Configs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,8 @@ class SystemConfig : public ConfigBase {
"enable_velox_task_logging"};
static constexpr std::string_view kEnableVeloxExprSetLogging{
"enable_velox_expression_logging"};
static constexpr std::string_view kEnableFbRemoteReportBuilderFunction{
"enable_fb_remote_report_builder_function"};
static constexpr std::string_view kLocalShuffleMaxPartitionBytes{
"shuffle.local.max-partition-bytes"};
static constexpr std::string_view kShuffleName{"shuffle.name"};
Expand Down Expand Up @@ -976,6 +978,8 @@ class SystemConfig : public ConfigBase {

bool enableVeloxExprSetLogging() const;

bool enableFbRemoteReportBuilderFunction() const;

bool useMmapAllocator() const;

std::string memoryArbitratorKind() const;
Expand Down
Loading