Skip to content

fix(ci): License check on yml files #26511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

fix(ci): License check on yml files #26511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions presto-native-execution/scripts/license-header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ def wrapper_hash(header, args):
}
)

file_pattern = regex.compile(
"|".join(["^" + fnmatch.translate(type) + "$" for type in file_types.keys()])
)


def get_filename(filename):
return os.path.basename(filename)
Expand Down Expand Up @@ -155,14 +151,25 @@ def main():

header_text = file_lines(args.header)

# fnmatch.translate can generate "\z" in the regex pattern
# which causes an error when compiled by regex:
# regex._regex_core.error: bad escape \z at position 23
# Usually, the pattern is generated with "\Z" which works fine.
raw_pattern = "|".join(
["^" + fnmatch.translate(type) + "$" for type in file_types.keys()]
)
pattern = raw_pattern.replace(r"\z", "\\Z")
message(log_to, "File pattern : " + pattern)
file_pattern = regex.compile(pattern)

if len(args.files) == 1 and args.files[0] == "-":
files = [file.strip() for file in sys.stdin.readlines()]
else:
files = args.files

for filepath in files:
filename = get_filename(filepath)

message(log_to, "File processed : " + filename)
matched = file_pattern.match(filename)

if not matched:
Expand Down
Loading