Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for osx arm64. Fix ppc64le download link. #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for osx arm64. Fix ppc64le download link. #22

wants to merge 3 commits into from

Conversation

wanglinsong
Copy link
Member

No description provided.

@wanglinsong wanglinsong mentioned this pull request May 13, 2023
Closed
yingsu00
yingsu00 reviewed May 13, 2023
View reviewed changes
Copy link

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Linsong it seems you have multiple changes in this PR ie

  • Update macOS from 10-11
  • Support arm
  • Update ppl URL address.
    It would be best if you can make them into separate commits.
    I'll further review the details on Sunday

@wanglinsong
Copy link
Member Author

Ok I will update this. BTW, the Jenkins pipeline is set to automate the check. But it looks like I have repo access issues.

@wanglinsong wanglinsong marked this pull request as draft May 13, 2023 15:07
@wanglinsong
Copy link
Member Author

The minimal mysql8 version with aarch64 support is 8.0.26, which runs on osx11. @yingsu00

@wanglinsong wanglinsong marked this pull request as ready for review May 14, 2023 07:08
@wanglinsong
Copy link
Member Author

https://ci.ahana.dev/job/prestodb/job/testing-mysql-server/view/change-requests/job/PR-22/

@wanglinsong
Copy link
Member Author

@yingsu00 I have tested this on both linux and macos aarch64.
Since the building/packaging only work on linux, I copied artifacts from a linux box to my macos to do the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingsu00 yingsu00 yingsu00 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanglinsong @yingsu00