Identified task and sprite fields related to battle weather animations #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.
|
Yep, casting to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named the task and sprite fields related to the battle animations for Hail, Rain Dance, and Sandstorm. Tested via
make clean && make -j16 && make compare; the hash matched.Description
HailStruct::unk3as a position type: fixed (i.e. always uses the position in the struct), negative (negative offset applied to a battler position, if battler is present; position in the struct otherwise), or positive. Renamed the field totype, and added an enum for the values.#defineand#undeffor the task data and sprite data for these three moves.ARRAY_COUNT, but using that macro causes the build to fail to match, so I left the constants untouched and noted the equivalence in line comments.Discord contact info
@davidjcobb