Skip to content

Voicegroup refactor and rename #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Voicegroup refactor and rename #2149

merged 1 commit into from
Jul 30, 2025

Conversation

ShinyDragonHunter
Copy link
Contributor

@ShinyDragonHunter ShinyDragonHunter commented Jun 2, 2025 •
edited
Loading

Voicegroups were given names and given a macro that aligns them by 2 like before and has an optional parameter for starting note which drumset voicegroups use to shift backwards to get the correct starting point (note 36 for most if not all). More splits have been done with the voicegroup files too including separating what looks like unused voicegroup data.

Description

Adds a new macro for use in voicegroups. If a starting_note the offset is shifted by the specified value * 0xC which is the length of a single voice (or ToneData_size in m4a_constants.inc) in a voicegroup

	.macro voice_group label:req, starting_note
	.align 2
	.ifb \starting_note
		.global voicegroup_\label 
		voicegroup_\label:
	.else
		.set voicegroup_\label, . - \starting_note * 0xC
	.endif
	.endm

Discord contact info

ShinyDragonHunter#2440

@ShinyDragonHunter
Allow names for voicegroups and use a macro for use with drumsets
db316c9 
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
@mrgriffin mrgriffin merged commit 0dfec24 into pret:master Jul 30, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2025
@mrgriffin
Allow names for voicegroups and use a macro for use with drumsets (#2149
632d0ab 
)
@hedara90 hedara90 mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShinyDragonHunter @mrgriffin