Fix potential stack memory leak in gbagfx due to out of bounds read #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
approved these changes
Jul 21, 2025
ShinyDragonHunter
pushed a commit
to ShinyDragonHunter/pokeemerald
that referenced
this pull request
Jul 31, 2025
…ret#2162) * fix(tools): gbagfx potential oob read --------- Co-authored-by: sbird <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gbagfxparses the-num_colorscli argument and accepts values greater than the maximum amount of colors stored in astruct Palette(256) leading to an out of bounds read if high values are passed to gbagfx.Description
Example behavior:
Fix:
Discord contact info
karathan