Name pokemon summary screen remaining unnamed symbols #2178
+143
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FosterProgramming
force-pushed
the
pret_update
branch
2 times, most recently
from
5d87033 to
a5835ba
Compare
FosterProgramming
force-pushed
the
pret_update
branch
from
a5835ba to
b6742ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to name the symbols describing the windows that "open" and "close" on the pokemon summary screen.
Description
I usually work on expansion but I had to stuff with the pokemon summary screen so I thought I would make a commit about the unnamed symbols. I don't think the names are great but they are better than a, b and field_4.
Basically, the game make the status window as well as the move details windows appear over a few frames by loading a few columns of the tilemap every frame so that it looks like the window is sliding
I am NOT interested in debating what the corrected names should be. Please change them to whatever you think is better, I just did it the way it made sense for me and I made a PR because I thought bad names were better than no names.
Discord contact info
Jamie (foster_harmony)