Synced Trainer Memo file with pokeheartgold #665
Conversation
|
|
||
| static void FormatDateAndLocationMet(PokemonInfoDisplayStruct *infoDisplay, int msgNo) | ||
| { | ||
| Strbuf *str = Strbuf_Init((((2 * 18) * 2) * 8), infoDisplay->heapID); |
There was a problem hiding this comment.
note: The surrounding context implies to me that 72 ((2 * 18) * 2) is the character-allocation size for an individual template parameter within this domain. I think that it's worth listing as a constant for this source file.
Funnily, this means that the 8 here is a potential buffer-overflow that may never have been realized in the retail game.
There was a problem hiding this comment.
note: The surrounding context implies to me that
72((2 * 18) * 2) is the character-allocation size for an individual template parameter within this domain. I think that it's worth listing as a constant for this source file.Funnily, this means that the
8here is a potential buffer-overflow that may never have been realized in the retail game.
I haven't worked with string templates yet, so I'm unsure how this should be handled. Any recommendations?
There was a problem hiding this comment.
The template itself isn't a huge deal for this specific instance, but, essentially, templates interpolate their arguments by index. They operate very similarly to, e.g. Python's formatting strings.
AsparagusEduardo
force-pushed
the
pret/pr/sinjoh/trainerMemo
branch
from
9c94d10 to
d52148d
Compare
AsparagusEduardo
force-pushed
the
pret/pr/sinjoh/trainerMemo
branch
from
d52148d to
bd18fff
Compare
AsparagusEduardo
added
the
pokeheartgold sync
The file was mostly untouched in pokeplatinum, so most of the changes will be migrated from pokeheartgold.
Matching PR: pret/pokeheartgold#397