Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #298

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add prettier #298

wants to merge 5 commits into from

Conversation

ryanto
Copy link
Contributor

@ryanto ryanto commented Mar 19, 2020

No description provided.

@xg-wang
Copy link
Member

xg-wang commented Mar 21, 2020

Thanks for adding Prettier! Can you also add a precommit hook to prettify code? https://prettier.io/docs/en/precommit.html

@ryanto
Copy link
Contributor Author

ryanto commented Mar 24, 2020

We were exploring adding this to Mirage, but I got some negative feedback (see https://twitter.com/ryantotweets/status/1203065809167409154). I'm not sure if it's worth adding.

I can add the prettier check to CI so we can failures if someone opens a PR with unformatted code. How does that sound?

@xg-wang
Copy link
Member

xg-wang commented Mar 24, 2020

Pretender doesn't run lint in ci now, I think adding prettier eslint integration and make it easier to yarn eslint --fix should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants