fix: passthrough for binary files #363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
|
@xg-wang as requested #305 (comment) Let me know if there's anything I can do to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
Fixes #72
Fixes miragejs/ember-cli-mirage#1915
I don't actually fully understand the change being made here, I've just converted the fix from this comment into a PR #305 (comment)
It works great for me. Full credit to @ankology
Happy to adjust this PR to update with any suggestions. Would love for it to be merged, but even if it doesn't it at least provides an easier way for people to see the code diff & write their own pnpm patches or point their repos at this branch.
Unrelated, but I would implore this fix PR be merged as well #355
It's another passthrough bug that I've had to write a pnpm patch for in my projects.