Fix issue that .prettierignore in monorepo sub folders is not read. (#3003, #3424) #3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you have some time @ntotten, do you think it would be possible to consider this PR, or did you have any concerns with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith a summary of your changesThis issue has been metion in thread #3003 and #3424. Currently, Prettier only reads .pretterignore file from directories included by .code-workspace or root project directory. However, in monorepo cases, we prefer no .code-workspace is created, and packages are organized by subdictories.
My main change is to prioritize reading the .prettierignore file alongside the .prettierrc file (I believe is the most common usage). If it does not exist, the current logic will still be attempted.