-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support prettier 3.0 #165
Conversation
ok sorry, When I have a failing prettier file, if I leave off --check I get the above exception. But when I add the check param then it says there are no issues, even though there are. probably because |
Curious if anyone has published this branch (or would be interested in a forked publish as v2.0.0) of this? @mgabeler-lee-6rs I'm happy to help with that, or you could publish it under your npm namespace - totally up to you! |
@JaKXz I've put this on hold because, while this allows If you want to use my branch to publish a variant with the fixes from here, and take a stab at fixing lukeapage's issue above, I have no objections, this is all open source after all :) |
I published the fix on npm - @lukeapage/pretty-quick |
I'll take over @azz's place and help to maintain this package in few days. 🍻 |
I'm trying to migrate this package to pure ESM but failed due to testing issues, jest does not support ESM well yet, vitest does not support support inspecting core modules (not sure). So I'll keep it as commonjs currently, and will try to migrate to dual package later. OK, related to tschaub/mock-fs#380 |
I have to reset this PR because it is full of bugs actually... I'll rewrite the whole package with TypeScript. |
When using prettier v3.2.5 along with pretty-quick v4.0.0 then I am still getting this error:
Logs: https://github.com/bennycode/trading-signals/actions/runs/8104997828/job/22152606896?pr=651 Any updates on this, @JounQin? |
You need upgrade |
Thank you!! I upgraded from eslint-plugin-prettier v4.2.1 to eslint-plugin-prettier v5.0.1 and it worked. 🥳 |
This seems to work for me, but I haven't been able to test if fully
Fixes #164