Refactor - Use TypeScript's variadic tuple types instead of T1,T2,... #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Looks great!
But it is not exactly the same as before.
I've tried both versions using Typescript Playground and noticed a difference:
- Before the change (see the playground):
- After the change (see the playground):
I'm sorry, I don't have time now to find what's wrong exactly. So I won't suggest ways of fixing it.
Maybe you'll want to find the problem? ;)
|
Oh I wasn't aware of the mismatch. Thanks for reviewing 🫶 I believe it's not an easy fix, we don't get much benefit out of this refactor too, so let's close it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.