-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/130 fr int 06 generate follow up questions #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gudals2040
merged 4 commits into
dev
from
feat/130-FR-INT-06-generate-follow-up-questions
Mar 11, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/main/java/com/aibe/team2/domain/interview/dto/InterviewReportResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.aibe.team2.domain.interview.dto; | ||
|
|
||
| import com.aibe.team2.domain.interview.entity.InterviewSession; | ||
| import com.aibe.team2.domain.interview.enums.InterviewMode; | ||
| import com.aibe.team2.domain.interview.enums.InterviewSessionStatus; | ||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| @Getter | ||
| @Builder | ||
| public class InterviewReportResponse { | ||
| private Long sessionId; | ||
| private InterviewMode interviewMode; | ||
| private String interviewType; | ||
| private InterviewSessionStatus status; | ||
| private Integer finalScore; | ||
| private LocalDateTime createdAt; | ||
|
|
||
| // 연관된 이력서와 공고의 '제목'을 프론트엔드에 전달하기 위한 필드 | ||
| private String resumeTitle; | ||
| private String jobTitle; | ||
|
|
||
| public static InterviewReportResponse of(InterviewSession session, String resumeTitle, String jobTitle) { | ||
| return InterviewReportResponse.builder() | ||
| .sessionId(session.getId()) | ||
| .interviewMode(session.getInterviewMode()) | ||
| .interviewType(session.getInterviewType()) | ||
| .status(session.getStatus()) | ||
| .finalScore(session.getFinalScore()) | ||
| .createdAt(session.getCreatedAt()) | ||
| .resumeTitle(resumeTitle) | ||
| .jobTitle(jobTitle) | ||
| .build(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IllegalStateException이 발생했을 때HttpStatus.FORBIDDEN(403)을 반환하도록 구현하셨습니다. 하지만 403은 인증된 사용자가 리소스에 접근할 권한이 없을 때 사용하는 상태 코드입니다. 이 경우, 사용자는 자신의 면접 리포트에 접근할 권한이 있지만, 면접이 아직 완료되지 않아 리소스의 상태가 요청을 처리하기에 적절하지 않은 상황입니다.이러한 "상태 충돌" 상황에는
HttpStatus.CONFLICT(409)가 더 적합한 상태 코드입니다. API의 의미를 더 명확하게 전달하기 위해 상태 코드를 변경하는 것을 고려해 보세요.