style(TreeTable): add highlight for rows selected with checkbox #7406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
KumJungMin
commented
Nov 11, 2024
| @@ -776,7 +776,7 @@ | |||
| background: #111827; | |||
| width: 22px; | |||
| height: 22px; | |||
| color: rgba(255, 255, 255, 0.87); | |||
| color: #212529; | |||
There was a problem hiding this comment.
Question
- In this PR(#6219), the checkbox color was applied in reverse for dark mode and light mode.
- Is there a separate repository for styles? If so, which repository should I modify?
If there isn’t a separate repository, I will make the necessary adjustments in this PR :)
There was a problem hiding this comment.
Yes the styles are here: https://github.com/primefaces/primereact-sass-theme
There was a problem hiding this comment.
you would make a change to the SCSS and regenerate all the themes.
There was a problem hiding this comment.
Instead of changing the theme color, I configured the checkboxIcon property to function similarly to the DataTable's checkbox property. :) (b1b99f4)
primereact/components/lib/datatable/RowCheckbox.js
Lines 35 to 40 in e86ddcc
KumJungMin
changed the title
melloware
requested changes
Nov 11, 2024
| @@ -776,7 +776,7 @@ | |||
| background: #111827; | |||
| width: 22px; | |||
| height: 22px; | |||
| color: rgba(255, 255, 255, 0.87); | |||
| color: #212529; | |||
There was a problem hiding this comment.
you would make a change to the SCSS and regenerate all the themes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Changes