-
Notifications
You must be signed in to change notification settings - Fork 9
feature: Checkout Components #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
borisprimer
wants to merge
448
commits into
master
Choose a base branch
from
bn/feature/checkout-components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 205 commits
Commits
Show all changes
448 commits
Select commit
Hold shift + click to select a range
285d3c1
update gitignore
BorisNikolic a76a2af
Merge branch 'bn/feature/checkout-components' of https://github.com/p…
BorisNikolic 8aa276f
remove unused code
BorisNikolic 4136224
remove unused code
BorisNikolic 07766b4
Delete Sources/PrimerSDK/CLAUDE.md
borisprimer 3f62585
Delete Sources/PrimerSDK/Classes/CLAUDE.md
borisprimer 8348e78
remove unused code
BorisNikolic 2252884
remove unused code
BorisNikolic 7241f8e
remove android reference from comments
BorisNikolic 1b8d025
remove redundant code
BorisNikolic 688d038
remove obsolete code
BorisNikolic 97d7627
Remove over-engineered navigation animation system and implement simp…
BorisNikolic a365505
Delete .claude/agents/ultra-senior-mobile-engineer.md
borisprimer e6471dd
Delete .claude/settings.local.json
borisprimer 19610b2
Delete Sources/PrimerSDK/Classes/Core/CLAUDE.md
borisprimer 7bae31d
Delete Sources/PrimerSDK/Classes/Data Models/CLAUDE.md
borisprimer 46b8c9d
Delete Sources/PrimerSDK/Classes/PCI/CLAUDE.md
borisprimer c97d82c
Delete Sources/PrimerSDK/Classes/PaymentMethods/CLAUDE.md
borisprimer f65d86d
Delete Sources/PrimerSDK/Classes/Services/CLAUDE.md
borisprimer fa84dc5
Delete Sources/PrimerSDK/Classes/User Interface/CLAUDE.md
borisprimer 9ea24ad
Delete CLAUDE.local.md
borisprimer 1b5b40f
remove comments
BorisNikolic e95d6f9
remove dead code
BorisNikolic 67ba973
Remove duplicated code
BorisNikolic 99ba65a
fix failing test
BorisNikolic 06641be
Revert useless changes
BorisNikolic d275e4b
remove unused file
BorisNikolic a4286ca
put the logs back in use
BorisNikolic 4aba3c8
code tidy
BorisNikolic c8ada8a
improve architecture relations
BorisNikolic ad0a5ab
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic 7666869
remove unused code
BorisNikolic 7134368
remove unused initialisers
BorisNikolic df1d16a
update readme file
BorisNikolic 47a4113
rename a variable
BorisNikolic e35b61c
remove unused code
BorisNikolic 567ce23
remove unused method
BorisNikolic b902edd
fix pod linting issues
BorisNikolic c3bba3d
swiftlint fix format
BorisNikolic ad826b9
fix pod lint fail
BorisNikolic 83f115b
fix actor isolation errors
BorisNikolic 6af4550
fix warnings
BorisNikolic 6585fae
prune logs and fix pod lint errors
BorisNikolic 95d2db9
add missing files to spm debug app
BorisNikolic d011f6d
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic d8fe66f
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic a685194
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic d754d10
Merge branch 'master' into bn/feature/checkout-components
borisprimer 865d58a
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic b4771fe
Merge branch 'master' into bn/feature/checkout-components
borisprimer bd3c256
fix: Ensure Cancel button dismisses checkout sheet (#1364)
OnurVar 9b74bb2
chore: Address PR review comments for CheckoutComponents documentatio…
borisprimer e3e9cd5
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic 94b8927
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic 449ace9
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic 5276445
fix: Enable dark mode in checkout components (#1376)
OnurVar 4349261
chore: Localization cleanup - Remove duplicates and use existing keys…
borisprimer a878e9f
Merge branch 'master' into bn/feature/checkout-components
borisprimer 0ab473e
remove unused code
BorisNikolic b7bfb70
Remove unused navigation code
BorisNikolic b3ae3a0
Remove a bunch of unused code
BorisNikolic b9b4aa7
Fix interactor initialization
BorisNikolic af7a414
update some strings
BorisNikolic 4e0ae46
Remove unused code
BorisNikolic bdba891
refactor: Implement dynamic sheet height for UIKit CheckoutComponents…
OnurVar 431304d
Display all payment methods, remove filtering
BorisNikolic e51e618
chore: Implement analytics for Checkout Components (#1379)
borisprimer 954ee40
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic fc102be
refactor: Address code review feedback for checkout components (#1378)
OnurVar b9003c8
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic 9bd7763
chore: ACC-5723 PrimerSettings integration in CheckoutComponents (#1382)
borisprimer 52b7e1b
Add AI-related files to the repo
BorisNikolic 29b0976
chore: Standardize headers in Checkout Components (#1399)
henry-cooper-primer 84dc115
refactor: Implement design tokens and pixel-perfect input UI (#1393)
OnurVar a8aa380
chore: ACC-5724 Comprehensive Accessibility Support (#1398)
borisprimer 4f83cf3
Merge branch 'master' into bn/feature/checkout-components
BorisNikolic a8c15c7
feat: Add co-badged card network selection for CheckoutComponents (#1…
OnurVar 9b132bb
chore: ACC-6311 Validate and Fix Critical CheckoutComponents Flows (#…
borisprimer 4bfac22
Merge branch 'master' into bn/feature/checkout-components
borisprimer 0dd7eaa
chore: DI improvements, billing address, co-badged card fixes, and co…
borisprimer 72d1f33
Merge branch 'master' into bn/feature/checkout-components
borisprimer c6a1b3a
chore: Add PAYMENT_REATTEMPTED analytics event tracking (#1444)
borisprimer 3f65d8d
feat: Add Apple Pay to CheckoutComponents (#1440)
OnurVar 26667cc
feat: Add Vault functionality to Checkout Components (#1438)
OnurVar 114379d
Merge branch 'master' into bn/feature/checkout-components
OnurVar 377c72c
Make fonts overridable
borisprimer 973667a
Merge remote-tracking branch 'origin/master' into bn/feature/checkout…
OnurVar 66c9bb4
test: Add foundation test infrastructure for CheckoutComponents (#1454)
OnurVar d724d89
test: Add DI container core unit tests for CheckoutComponents (#1455)
OnurVar dfba26b
test: Add DI SwiftUI integration tests for CheckoutComponents (#1456)
OnurVar 21bf171
Merge origin/master into bn/feature/checkout-components
OnurVar 1013d82
style: Apply swiftformat fixes to CheckoutComponents
OnurVar 6ea2ec8
test: Fix flaky test_state_emitsCurrentState race condition
OnurVar 639d96e
test: Add Validation Pt2 unit tests for CheckoutComponents (#1459)
OnurVar 660a6a8
test: Add Navigation unit tests for CheckoutComponents (#1460)
OnurVar 1a4f0fd
chore: Upgrade Xcode from 16.3.0 to 16.4.0
OnurVar 48a2068
Merge remote-tracking branch 'origin/master' into bn/feature/checkout…
OnurVar f1af4bd
Merge remote-tracking branch 'origin/ov/chore/upgrade-xcode-16.4' int…
OnurVar a7db6c5
test: Add accessibility unit tests for CheckoutComponents (#1457)
OnurVar aefc81d
test: Add HeadlessRepo Pt1 unit tests for CheckoutComponents (#1463)
OnurVar cbb69e1
fix: Resolve flaky test in DefaultApplePayScopeTests
OnurVar 47a8a21
refactor: Reorganize TestData into domain-focused extensions
OnurVar 7b56248
test: Add validation unit tests for CheckoutComponents (#1458)
OnurVar d7103b0
feat: Add Datadog logging for CheckoutComponents (#1493)
OnurVar fcee370
Merge branch 'master' into bn/feature/checkout-components
borisprimer 60c57b6
refactor: Address PR review feedback for Datadog logging (#1498)
OnurVar 2eb0b94
style: Fix SwiftFormat import sorting
OnurVar 91c1030
Merge remote-tracking branch 'origin/master' into bn/feature/checkout…
OnurVar cd22b1d
chore: Sync translations between the platforms (#1446)
borisprimer 668f9bd
Merge branch 'master' into bn/feature/checkout-components
borisprimer e196962
test: Add HeadlessRepo Pt2 unit tests for CheckoutComponents (#1469)
OnurVar cb1755d
refactor: Consolidate Datadog logging into LoggingService (#1502)
OnurVar dd49ead
feat: ACC-6684 Klarna on Checkout Components (#1514)
borisprimer ef3302b
Add all files to the project
borisprimer 6b388d2
Implement SecureTextField
borisprimer 300d046
test: Add HeadlessRepo Pt3 unit tests for CheckoutComponents (#1472)
OnurVar b139f42
test: Add Interactor unit tests for CheckoutComponents (#1473)
OnurVar 7074020
Merge branch 'master' into bn/feature/checkout-components
borisprimer ac67254
feat: Add idempotency key support for Drop-In and Headless flows
borisprimer 78ac522
Merge branch 'bn/feature/ACC-6756-idempotency-key' into bn/feature/ch…
borisprimer 08e1484
fix: Apply Turkish language rules to tr translations
OnurVar c2b0426
feat: ACC-6691 ACH on Checkout Components (#1520)
borisprimer c281d95
feat: Add idempotency key support for to CheckoutComponents (#1526)
borisprimer dceb417
chore: Unify CheckoutComponents public API naming and add documentati…
borisprimer 86bfce0
chore: Clean up CheckoutComponents public API inconsistencies
borisprimer bb68955
fix build error
borisprimer e5bcf9f
feat: Add WebRedirect APM to Checkout Components (#1515)
OnurVar da06da3
feat: Add translations and accessibility strings for WebRedirect APM …
OnurVar 77a7cc1
feat: Add analytics events for WebRedirect APM (#1543)
OnurVar 97b3059
test: Add unit tests for WebRedirect APM (#1538)
OnurVar 137aca1
feat: Add FormRedirect APM to Checkout Components (#1529)
OnurVar 0360c0e
feat: Add translations and accessibility for FormRedirect APM (#1535)
OnurVar 05e8b32
feat: Add analytics events for FormRedirect APM (#1536)
OnurVar 5cc44bc
test: Add unit tests for FormRedirect APM (#1542)
OnurVar 4e1f50a
feat: Add QR Code APM to Checkout Components (#1537)
OnurVar 4e054c0
feat: Add translations and accessibility strings for QR Code APM (#1540)
OnurVar 04780bc
test: Add unit tests for QR Code APM (#1541)
OnurVar 03fa4c0
feat: Add analytics events for QR Code APM (#1544)
OnurVar 8ffe6a7
feat: Add onBinDataAvailable support (Headless + CheckoutComponents) …
borisprimer f1035b3
chore: Enforce Swift coding style via SwiftFormat and SwiftLint (#1534)
borisprimer 0ef55c3
feat: Filter unsupported payment methods and map display metadata (#1…
borisprimer 7092f69
refactor: Improve CheckoutComponents code quality and safety (#1566)
borisprimer 3c96b3c
chore: Rename before public docs release (#1560)
borisprimer 541bb51
chore: Merge master into bn/feature/checkout-components
borisprimer 1e41322
fix: Correct Mastercard card number formatting gaps (ACC-6816) (#1583)
OnurVar 05a1413
chore: Merge master into bn/feature/checkout-components
OnurVar 9537711
Release 3.0.0-b0 (#1599)
primer-security-integrations 1f6452d
chore: Optimize Claude Code configuration (#1576)
borisprimer d6699ef
Merge branch 'master' into bn/feature/checkout-components
borisprimer 7a482b7
chore: Apply coding style rules to CheckoutComponents public API (Sco…
borisprimer 4da374f
chore: Apply coding style rules to CheckoutComponents Debug App (#1620)
borisprimer e09c8e9
chore: Apply coding style rules to CheckoutComponents Tests (#1619)
borisprimer 36a8694
chore: Apply coding style rules to CheckoutComponents PaymentMethods …
borisprimer 1c1966d
chore: Apply coding style rules to CheckoutComponents Analytics + Log…
borisprimer 599c92d
chore: Apply coding style rules to CheckoutComponents Presentation Co…
borisprimer 155d386
chore: Apply coding style rules to CheckoutComponents Domain + Naviga…
borisprimer 69fba64
chore: Apply coding style rules to CheckoutComponents Internal Core (…
borisprimer dce4ce9
chore: Apply coding style rules to CheckoutComponents Presentation Sc…
borisprimer 4dc956e
chore: Apply coding style rules to CheckoutComponents Presentation Sc…
borisprimer 103611d
fix: Remove extraneous argument label in ApplePayScreen
OnurVar 6f93d68
test: Remove low-value ApplePay tests and consolidate shared mocks (#…
OnurVar 04dc14e
test: Add Scope Pt1 unit tests for CheckoutComponents (#1478)
OnurVar 15b0936
test: Add PayPal & Methods unit tests for CheckoutComponents (#1477)
OnurVar f32085e
fix: Add SyncCache to prevent resolveSync deadlock on main thread
borisprimer 7105690
fix: Add onBeforePaymentCreate hooks to PayPal, WebRedirect, FormRedi…
borisprimer 15b83b6
fix: Move downcast helper from protocol extension to concrete class
borisprimer ca61e2f
fix: Fix onDismiss race condition and navigation Task memory leak
borisprimer 78429a6
fix: Fix memory leaks and correctness issues in DefaultCardFormScope
borisprimer c56ebb4
fix: Add @MainActor to ApplePayAuthorizationCoordinator
borisprimer b1a8d8a
fix: Close PCI masking gaps in logging pipeline
borisprimer c9b832a
fix: Remove debug print statements that log card data in production
borisprimer 7360bd7
fix: Add OneShotContinuation and vault payment timeout in HeadlessRep…
borisprimer 6a5ca22
fix: Make RawDataManager delegate weak and prevent wipe callbacks
borisprimer dc04b95
fix: Resume continuation on unexpected polling status
borisprimer e592498
fix: Fix DI framework issues (TOCTOU race, unused container, self-cap…
borisprimer 3741058
chore: Remove unused DI-SwiftUI code and move metrics behind #if DEBUG
borisprimer 225c373
fix: Fix public API annotations and scope protocol cleanup
borisprimer d3535da
fix: Fix Task leaks, dead code, and accessibility across checkout scr…
borisprimer 6f355f3
fix: Fix Equatable, duplicate onChange, dead code, and googlePay icon
borisprimer 23aa7dc
chore: Remove dead code and fix accessibility/validation issues
borisprimer 421bd32
fix: Fix analytics event buffer, dead code, and discarded Task
borisprimer b31d674
fix: Add @available(iOS 15.0, *) to PaymentMethodMapper protocol
borisprimer 275110f
refactor: Rename _paymentMethodSelection to cachedPaymentMethodSelection
borisprimer a57ddef
pod install
borisprimer 33b6e76
fix: Add @MainActor to PrimerCheckoutPresenter
borisprimer f5b5e63
fix: Chain dismiss completion after UIKit animation finishes
borisprimer 9ec6ed8
fix: Replace hardcoded English accessibility label with localized string
borisprimer ea8a85d
fix: Restore %d placeholder in French accessibility_error_multiple_er…
borisprimer 00efae8
fix: Use type-safe enum comparison for AMEX CVV length check
borisprimer e795fd9
fix: Use single Date instance and handle 4-digit year in expiry valid…
borisprimer 8ef1a1f
fix: Use raw string as validation cache key instead of hash
borisprimer 85bff2f
chore: Remove unused generic validation rules
borisprimer 1785346
chore: Add final to DesignTokens and DesignTokensDark classes
borisprimer 408bf23
chore: Add final to PaymentMethodsBridge and remove emoji from logs
borisprimer 24f5191
fix: Replace hardcoded English retail outlet error strings
borisprimer bb73547
fix: Strip spaces from card number before sending to payment interactor
borisprimer 11bc57c
chore: Remove unused maskedCardNumber string constant
borisprimer 2f7e5c8
fix: Clear validation cache on checkout session cleanup
borisprimer a4a85e7
fix: Add accessibility configuration to 5 input fields
borisprimer 6835c43
feat: Add accessibility hint translations for input fields
borisprimer b798679
feat: Add 29 missing translation keys for Web Redirect, Form Redirect…
borisprimer dd7da3b
feat: Complete translations for all 56 languages
borisprimer c5ba5b2
fix: Fix type mismatch in accessibility identifier for input fields
borisprimer e65aed8
docs: Add v3.0 breaking change annotations to affected APIs
borisprimer d22de48
fix: Add VoiceOver screen-change announcements for ACH step transitions
borisprimer f375c59
fix: Add VoiceOver error announcements for card form validation
borisprimer 4a00bb8
fix: Add Sendable conformances to DI container for Swift 6
borisprimer d860a62
fix: Add @MainActor to HeadlessRepositoryImpl and PaymentCompletionHa…
borisprimer d8490fc
fix: Add @unchecked Sendable to all scope and repository classes for …
borisprimer 1948aed
fix: Add Swift 6 concurrency annotations to FontRegistration and Desi…
borisprimer 8c81c62
fix: Wrap @MainActor initializers in MainActor.run for DI registration
borisprimer 00e3170
test: Replace Task.sleep with Task.yield in HeadlessRepository tests
borisprimer d281c75
test: Replace 29 Task.sleep calls with awaitValue/expectations in Def…
borisprimer 2b60060
test: Fix pre-existing test compilation errors from review-fixes
borisprimer f9f953b
test: Replace 28 Task.sleep calls with awaitValue/expectations in Def…
borisprimer 1686f19
feat: ApplePayScreen full design system pass with localization + acce…
borisprimer 632740b
perf: SwiftUI architecture refactors — P1, P3, P7, P8, C3
borisprimer cd2d993
fix: Resolve 6 pre-existing test failures
borisprimer 13ca493
test: Add 131 new tests across 6 untested components
borisprimer c1234d2
test: Add ~700 tests and refactor repositories for 80%+ coverage
borisprimer 1e21a4d
fix: Clean analytics storage in setUp to prevent test pollution
borisprimer d40c7f6
chore: Run swiftformat and swiftlint --fix on CheckoutComponents
borisprimer 1c57699
fix: Add PaymentMethodButton accessibility and remove dead setBilling…
borisprimer 164a4af
fix: Resolve resolveSync deadlock when called from @MainActor context
borisprimer e226298
fix: Resolve compiler warnings across SDK and CheckoutComponents
borisprimer f08a8b1
update git ignore
borisprimer c5ac437
perf: Async createScope migration for Swift 6 readiness
borisprimer 307d7a2
Merge branch 'master' into bn/feature/checkout-components
borisprimer 711777b
fix: Resolve test failures in ApplePay and GiroPay tests
borisprimer d2c3ec7
fix: Align analytics and logging payloads with cross-platform spec (#…
OnurVar 97b65fa
fix: Address review findings for CheckoutComponents
borisprimer 6ff43c2
Merge remote-tracking branch 'origin/master' into bn/feature/checkout…
borisprimer 832d1b9
feat: Implement ADYEN_KLARNA in CheckoutComponents (#1664)
borisprimer 0770303
feat: Add MOLLIE_GIFTCARD payment method type (#1663)
borisprimer a31d5e7
feat: Add ComponentsAnalyticsLoggingBridge for React Native SDK (#1668)
OnurVar e429ddf
fix: Hide 'choose other payment method' on error screen for single PM…
borisprimer 81d468b
fix: Make PaymentMethodRegistry.reset() available in Release builds (…
borisprimer 7d4d9b6
fix: Replace selectCountry getter side effect with lazy var (#1695)
borisprimer 995a01a
refactor: Break down DefaultCheckoutScope into focused types (#1698)
borisprimer 24dda2c
fix: Reset DI container between CheckoutComponents tests (#1706)
borisprimer 84e1866
fix: Pass correct paymentMethodType to QRCode interactor (#1693)
borisprimer 59c129a
fix: Propagate critical DI registration failures in ComposableContain…
borisprimer 6656fa8
feat: Implement ADYEN_AFFIRM billing address redirect in CheckoutComp…
borisprimer c2fbfc6
refactor: Decouple card form field views from DefaultCardFormScope [A…
borisprimer 032f1af
Merge remote-tracking branch 'origin/master' into bn/feature/checkout…
OnurVar 19e75d0
fix: Pass status to PrimerCheckoutDataPayment init
OnurVar 25ce86b
style: Apply SwiftFormat to changed files
OnurVar ea67c1b
feat: Add ComponentsBillingAddressBridge for RN interop (#1727)
OnurVar 3006d5e
feat: Add ComponentsClientSessionBridge for RN interop (#1731)
OnurVar 3505a00
fix: Remove duplicate ClientSession.Address init
OnurVar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,54 @@ | ||
| disabled_rules: | ||
| - superfluous_disable_command | ||
| - type_body_length | ||
|
|
||
| line_length: | ||
| warning: 150 | ||
| ignores_function_declarations: true | ||
| ignores_comments: true | ||
| ignores_interpolated_strings: true | ||
| ignores_urls: true | ||
|
|
||
|
|
||
| file_length: | ||
| warning: 500 | ||
| error: 800 | ||
| ignore_comment_only_lines: true | ||
|
|
||
| function_body_length: | ||
| warning: 60 | ||
| error: 100 | ||
|
|
||
| cyclomatic_complexity: | ||
| warning: 12 | ||
| error: 20 | ||
| ignores_case_statements: false | ||
|
|
||
| function_parameter_count: | ||
| warning: 6 | ||
| error: 8 | ||
|
|
||
| included: | ||
| - ../Sources | ||
|
|
||
| excluded: | ||
| - ../Sources/PrimerSDK/Classes/Third Party/PromiseKit | ||
|
|
||
| # Configuration for type names: | ||
| # Enforces a minimum length of 3 and a maximum length of 40 characters, | ||
| # but excludes the generic type "T" from this rule. | ||
| type_name: | ||
| min_length: 3 | ||
| max_length: 40 | ||
| excluded: | ||
| - '^T$' # Regex to ignore type name "T" | ||
|
|
||
| # Configuration for identifier names: | ||
| # Enforces a minimum length of 3 and a maximum length of 40 characters, | ||
| # but excludes the loop counter "i" from this rule. | ||
| identifier_name: | ||
| min_length: 3 | ||
| max_length: 40 | ||
| excluded: | ||
| - '^i$' # Regex to ignore identifier "i" in for loops | ||
| - '^id$' # Regex to ignore identifier "id" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 20 additions & 2 deletions
22
...imer.io Debug App SPM.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here could do with their own discussion, some background on why we are moving from the defaults here. Not a blocker, but a change like this can stand alone.