refactor: SDK existing file modifications for CheckoutComponents by bthebladeprimer · Pull Request #1632 · primer-io/primer-sdk-ios

bthebladeprimer · 2026-03-26T15:37:39Z

Summary

Modifies 89 existing SDK files to support CheckoutComponents integration
Adds accessibility modifiers, new API endpoints, and protocol conformances needed by CheckoutComponents
Extends error handling, analytics, and data models with CheckoutComponents-specific cases
Updates Debug App with CheckoutComponents integration points
Adds new test files for DI, secure memory wipe, cache keys, and mock utilities

Context

PR 3 of 15 in the CheckoutComponents feature split. This is the highest-risk PR as it touches existing SDK files across the codebase. Depends on PR 2 (#1631).

Tracker: https://www.notion.so/32fca65dc30e81dabf66f33e2b58c3a1

Test plan

Verify existing unit tests pass with modifications
Review all 89 modified files for unintended changes
Confirm new test files compile and pass
Verify no breaking changes to public API surface
Run full test suite: xcodebuild -workspace PrimerSDK.xcworkspace -scheme PrimerSDKTests -destination "platform=iOS Simulator,name=iPhone 16" test

github-actions · 2026-03-26T15:38:33Z

	Warnings
⚠️	> Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.

Generated by 🚫 Danger Swift against 9c8d8ab

nquinn-primer · 2026-04-10T09:26:40Z

+                )
+            )

+        // Note: v3.0 breaking change — Mastercard formatting changed from [4, 10]


Curious where this change came from - product-led or something uncovered during development?

nquinn-primer · 2026-04-10T09:30:14Z

+/// ```
+/// - Note: **v3.0 breaking change**: This enum is now `public`. All cases are part of the
+///   public API contract — no cases can be removed or renamed without a breaking change.
+public enum PrimerPaymentMethodType: String, Codable, CaseIterable, Equatable, Hashable {


What is the rationale behind making this public?

I dont believe this is an exhaustive list due to how WEB_REDIRECT payment methods work, payment methods can be added and will work with the SDK without additions here. cc @henry-cooper-primer for a sense-check in case my worldview is out of date.

If it is not an exhaustive list of supported payment methods, it may be confusing to a merchant if exposed

I would also add that allowing the posibility for this to be extended by the merchant could cause unknown headaches

nquinn-primer · 2026-04-10T09:33:02Z

 extension URLSession: URLSessionProtocol {}

-final class DefaultRequestDispatcher: RequestDispatcher, LogReporter {
+final class DefaultRequestDispatcher: RequestDispatcher, @unchecked Sendable, LogReporter {


@unchecked here makes me nervous. Why is it needed? I would like to see unit tests which test multi-threaded behaviour if we need it, I worry about races/crashes if this runs on multiple threads.

nquinn-primer · 2026-04-10T09:35:38Z

+            return text.contains("@") && text.contains(".")
        default:
-            return true
+            return false


A latent bug, or was this required because the cases were not exhaustive before?

nquinn-primer · 2026-04-10T09:40:30Z

            DispatchQueue.main.async {
                rawDataManager.delegate?.primerRawDataManager?(
                    rawDataManager,
-                    metadataDidChange: ["cardNetwork": self.cardNetwork.rawValue]


metadataDidChange is deprecated, but here we stop sending data there. I would say either remove it, or send to both until removed

nquinn-primer

Nice work, added some comments

nquinn-primer · 2026-04-15T09:35:02Z

@@ -298,70 +336,55 @@ extension MerchantHeadlessCheckoutRawDataViewController: PrimerHeadlessUniversal
        let printableNetworks = metadata.detectedCardNetworks.items.map(\.network.rawValue).joined(separator: ", ")
        print("[MerchantHeadlessCheckoutRawDataViewController] didReceiveCardMetadata: \(printableNetworks) forCardValidationState: \(cardState.cardNumber)")


We shouldnt be exposing the unexposed cardnumber for PCI reasons. Can you check if we ever did this before with PrimerValidationState - is it something new in PrimerCardNumberEntryState?

nquinn-primer · 2026-04-15T09:38:23Z

-             .cvv,
-             .otp,
-             .phoneNumber:
+        case .cardNumber, .expiryDate, .cvv, .otp, .phoneNumber, .postalCode:


.postalCode has moved from .alphabet to .numberPad. This will cause issues in many countries where postalCode is not only numeric

nquinn-primer · 2026-04-15T09:40:31Z

        return true
    }

-    func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool {


DeepLink support removed? Is this intended?

If it is handled elsewhere, then please make sure to test all redirect methods and E2E tests which rely on this

nquinn-primer · 2026-04-15T09:44:20Z

+///
+/// You can enable multiple dismissal mechanisms by passing an array to `PrimerUIOptions`.
+/// For example, `[.gestures, .closeButton]` allows both swipe gestures and a close button.
+public enum DismissalMechanism: String, Codable {


A breaking change - fine since we are going to 3.0 but we will need to keep track of these public breaking changes for the future CHANGELOG

nquinn-primer · 2026-04-15T09:46:27Z

+        case .firstName, .lastName:
+            return text.isValidNonDecimalString
+        case .email:
+            return text.contains("@") && text.contains(".")


Perhaps we can use a more robust email regex - I would suggest aligning across platforms

nquinn-primer · 2026-04-15T09:47:09Z

+
+    /// Human-readable field name for display
+    var displayName: String {
+        switch self {


Should these display names be pulling from Localized strings?

nquinn-primer · 2026-04-15T09:48:25Z

+            return imgView
+        }
+
+        if Thread.isMainThread {


is this required since the function is @mainactor?

nquinn-primer · 2026-04-15T09:49:53Z

        XCTAssertEqual(report.recommendations.count, 2)
    }

-    // MARK: - printDetailedReport / printReport Tests


These tests are deleted but these code paths still exist in production. Intended?

…gration

This reverts commit d2f62bf.

Restore call to deprecated primerHeadlessUniveraslCheckoutUIDidDismissPaymentMethod in both PrimerDelegateProxy dismiss overloads to maintain backward compatibility with merchants still using the typo method name.

nquinn-primer · 2026-04-15T15:25:56Z

+        (internalText ?? "").isEmpty
    }

+    func wipe() {


This leaves data behind in memory since utf8CString returns a copy - I wonder is now a good time to resolve this and work towards killing this VULN ticket at the same time cc @marjaimate

bthebladeprimer requested review from a team as code owners March 26, 2026 15:37

bthebladeprimer mentioned this pull request Mar 26, 2026

feat: Add domain foundation + test data factory #1633

Open

4 tasks

bthebladeprimer self-assigned this Mar 26, 2026

bthebladeprimer marked this pull request as draft March 26, 2026 16:31

bthebladeprimer marked this pull request as ready for review April 3, 2026 18:09

nquinn-primer reviewed Apr 10, 2026

View reviewed changes

nquinn-primer reviewed Apr 15, 2026

View reviewed changes

bthebladeprimer force-pushed the bn/feature/cc-02-di-container branch from 637b7c4 to 01baa63 Compare April 15, 2026 12:59

bthebladeprimer added 7 commits April 15, 2026 14:59

refactor: SDK existing file modifications for CheckoutComponents inte…

083b3ec

…gration

chore: Add CheckoutComponents analytics interactor test

b1c2a6b

Revert "chore: Add CheckoutComponents analytics interactor test"

4cbd729

This reverts commit d2f62bf.

chore: Add CheckoutComponentsSettingsTests

8c4c659

fix: Restore deprecated dismiss callback for backward compatibility

53c2e77

Restore call to deprecated primerHeadlessUniveraslCheckoutUIDidDismissPaymentMethod in both PrimerDelegateProxy dismiss overloads to maintain backward compatibility with merchants still using the typo method name.

fix: Address review findings for CheckoutComponents

8abb0d0

chore: Fix SwiftFormat lint issues

9c8d8ab

bthebladeprimer force-pushed the bn/feature/cc-03-sdk-refactors branch from 2e87ec4 to 9c8d8ab Compare April 15, 2026 12:59

nquinn-primer reviewed Apr 15, 2026

View reviewed changes

		@@ -298,70 +336,55 @@ extension MerchantHeadlessCheckoutRawDataViewController: PrimerHeadlessUniversal
		let printableNetworks = metadata.detectedCardNetworks.items.map(\.network.rawValue).joined(separator: ", ")
		print("[MerchantHeadlessCheckoutRawDataViewController] didReceiveCardMetadata: \(printableNetworks) forCardValidationState: \(cardState.cardNumber)")

Conversation

bthebladeprimer commented Mar 26, 2026

Summary

Context

Test plan

Uh oh!

github-actions Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nquinn-primer Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nquinn-primer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Mar 26, 2026 •

edited

Loading

nquinn-primer Apr 10, 2026 •

edited

Loading