feat: Add validation system#1634
Open
bthebladeprimer wants to merge 2 commits into
Open
Conversation
Contributor
Generated by 🚫 Danger Swift against bb4a39d |
4 tasks
8e4c043 to
a9450d7
Compare
70b5a50 to
efa6da3
Compare
708e244 to
0e73d61
Compare
3220d09 to
bb4a39d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidationRuleprotocol andValidationResulttypes for composable field validationValidationServicethat orchestrates rule evaluation for form fieldsRulesFactoryfor creating validation rule sets per field typeExpiryDateInputmodel for structured expiry date handlingContext
PR 5 of 15 in the CheckoutComponents feature split. The validation system is used by the public API layer (PR 6) and all UI components. Depends on PR 4 (#1633).
Tracker: https://www.notion.so/32fca65dc30e81dabf66f33e2b58c3a1
Test plan
RulesFactoryreturns correct rules for each field typexcodebuild -workspace PrimerSDK.xcworkspace -scheme PrimerSDKTests -destination "platform=iOS Simulator,name=iPhone 16" test