feat: Add design tokens, theming & font system#1636
Open
bthebladeprimer wants to merge 2 commits into
Open
Conversation
Contributor
Generated by 🚫 Danger Swift against 90d9580 |
5 tasks
bthebladeprimer
force-pushed
the
bn/feature/cc-06-public-api
branch
from
b106d79 to
8940f4a
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-07-design-tokens
branch
from
be4aa75 to
b71d3ee
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-06-public-api
branch
from
3bf8f05 to
6cd9137
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-07-design-tokens
branch
from
c9092d5 to
90d9580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DesignTokensandDesignTokensDarkwith full light/dark mode token definitionsDesignTokensManagerfor runtime token resolution with appearance mode supportDesignTokensProcessorfor parsing and transforming JSON-based design token filesFontRegistrationandPrimerFontfor custom font loading and managementCheckoutColors,PrimerLayout,AnimationConstants,SlideInModifierDesignTokensManagerTests,DesignTokensProcessorTests,AppearanceModeTestsContext
PR 7 of 15 in the CheckoutComponents feature split. Provides the visual foundation (colors, typography, spacing, animations) for all UI components. Depends on PR 6 (#1635).
Tracker: https://www.notion.so/32fca65dc30e81dabf66f33e2b58c3a1
Test plan
DesignTokensManagerTestspasses (light/dark mode token resolution)DesignTokensProcessorTestspasses (JSON parsing edge cases)AppearanceModeTestspassesxcodebuild -workspace PrimerSDK.xcworkspace -scheme PrimerSDKTests -destination "platform=iOS Simulator,name=iPhone 16" test