Skip to content

feat: Add core interactors, mapper & bridge#1639

Open
bthebladeprimer wants to merge 2 commits into
bn/feature/cc-09-services-navigationfrom
bn/feature/cc-10-interactors-bridge
Open

feat: Add core interactors, mapper & bridge#1639
bthebladeprimer wants to merge 2 commits into
bn/feature/cc-09-services-navigationfrom
bn/feature/cc-10-interactors-bridge

Conversation

@bthebladeprimer
Copy link
Copy Markdown
Contributor

Summary

  • Add CheckoutComponentsPaymentMethodsBridge for bridging payment method data between legacy and new architecture
  • Add PaymentMethodMapper for mapping raw payment method config to domain models
  • Add PrimerPaymentMethodType+ImageName extension for resolving payment method icons
  • Add comprehensive test coverage for core interactors: card network detection, payment methods retrieval, card payment processing, input validation, and vaulted payment submission
  • Add test mocks: MockHeadlessRepository, MockRawDataManager, MockClientSessionActionsModule

Context

PR 10 of 16 in the CheckoutComponents feature split. Depends on PR 9 (core services & navigation).

Notion tracker

Test plan

  • CheckoutComponentsPaymentMethodsBridgeTests — verify payment method bridge data flow
  • CardNetworkDetectionInteractorTests — verify card network detection logic
  • GetPaymentMethodsInteractorTests — verify payment method retrieval
  • ProcessCardPaymentInteractorTests — verify card payment processing
  • SubmitVaultedPaymentInteractorTests — verify vaulted payment submission
  • ValidateInputInteractorTests — verify input validation rules
  • PaymentMethodMapperTests — verify mapping from raw config to domain models
  • PrimerPaymentMethodTypeImageNameTests — verify image name resolution

@bthebladeprimer bthebladeprimer requested a review from a team as a code owner March 26, 2026 15:49
@bthebladeprimer bthebladeprimer self-assigned this Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2026

Warnings
⚠️ > Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.

Generated by 🚫 Danger Swift against 3871834

@bthebladeprimer bthebladeprimer marked this pull request as draft March 26, 2026 16:32
@bthebladeprimer bthebladeprimer force-pushed the bn/feature/cc-09-services-navigation branch from 6d57497 to 0a8b7bc Compare March 31, 2026 14:07
@bthebladeprimer bthebladeprimer force-pushed the bn/feature/cc-10-interactors-bridge branch from 58fc9db to 0594847 Compare March 31, 2026 14:07
@bthebladeprimer bthebladeprimer marked this pull request as ready for review April 3, 2026 18:09
@bthebladeprimer bthebladeprimer force-pushed the bn/feature/cc-09-services-navigation branch from d0e13e1 to 04cf0f1 Compare April 15, 2026 13:02
@bthebladeprimer bthebladeprimer requested a review from a team as a code owner April 15, 2026 13:02
@bthebladeprimer bthebladeprimer force-pushed the bn/feature/cc-10-interactors-bridge branch from bd63963 to 3871834 Compare April 15, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant