feat: Add payment method verticals (8 methods)#1641
Open
bthebladeprimer wants to merge 3 commits into
Open
Conversation
Contributor
Generated by 🚫 Danger Swift against ddfc7fb |
7 tasks
bthebladeprimer
force-pushed
the
bn/feature/cc-11-headless-repository
branch
from
85a6802 to
4bcc4a5
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-12-payment-methods
branch
from
6331e36 to
0ca46cf
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-11-headless-repository
branch
from
59af837 to
2450a3c
Compare
The async Task in DefaultCheckoutScope.init() populates the scope cache after init returns. Tests calling createView() immediately get nil. Pre-populate the cache with a DefaultApplePayScope in the test helper.
bthebladeprimer
force-pushed
the
bn/feature/cc-12-payment-methods
branch
from
cf11538 to
ddfc7fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AchRepositoryImpl,FormRedirectRepositoryImpl,KlarnaRepositoryImpl,PayPalRepositoryImpl,QRCodeRepositoryImpl,WebRedirectRepositoryImplProcessAchPaymentInteractor,ProcessApplePayPaymentInteractor,ProcessFormRedirectPaymentInteractor,ProcessKlarnaPaymentInteractor,ProcessPayPalPaymentInteractor,ProcessQRCodePaymentInteractor,ProcessWebRedirectPaymentInteractorApplePayRequestBuilderhelper for constructing Apple Pay payment requestsContext
PR 12 of 16 in the CheckoutComponents feature split. Depends on PR 11 (HeadlessRepository implementation).
Notion tracker
Test plan
AchPaymentMethodTests,AchRepositoryImplTests,AchStateTests,DefaultAchScopeTests,ProcessAchPaymentInteractorTestsApplePayPaymentMethodTests,ApplePayRequestBuilderTests,ApplePayAuthorizationCoordinatorTests,DefaultApplePayScopeTests,ProcessApplePayPaymentInteractorTestsCardPaymentMethodTestsFormRedirectPaymentMethodTests,FormRedirectRepositoryImplTests,FormRedirectStateTests,DefaultFormRedirectScopeTests,ProcessFormRedirectPaymentInteractorTestsKlarnaPaymentMethodTests,KlarnaRepositoryImplTests,KlarnaRepositoryTests,DefaultKlarnaScopeTests,ProcessKlarnaPaymentInteractorTests,PrimerKlarnaStateTestsPayPalPaymentMethodTests,PayPalRepositoryImplTests,ProcessPayPalPaymentInteractorTestsQRCodePaymentMethodTests,QRCodeRepositoryImplTests,DefaultQRCodeScopeTests,ProcessQRCodePaymentInteractorTestsWebRedirectPaymentMethodTests,WebRedirectRepositoryTests,DefaultWebRedirectScopeTests,ProcessWebRedirectPaymentInteractorTestsPaymentMethodRegistryTests— verify payment method registrationInvokeBeforePaymentCreateTests,VaultedPaymentMethodDisplayDataTests,VaultedCardCVVInputTests,SecureTextFieldTests