Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on icon colors for the ActionMenu items #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update guidance on icon colors for the ActionMenu items #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions content/components/action-menu.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,27 @@ Especially when providing single or multi select items that rely on a crossmark
</Dont>
</DoDontContainer>

In order to maintain a consistent apperance, avoid using colored icons as a leading visual. Colored icons should be reserved for destructive actions.

<DoDontContainer>
<Do>
<img
width="464"
alt="Do"
src="https://user-images.githubusercontent.com/1295166/277831671-5b063a9e-06cd-4585-a0dc-0883a67e2deb.png"
/>
<Caption>Avoid using colored icons for standard menu items. This makes desctructive actions stand out.</Caption>
</Do>
<Dont>
<img
width="464"
alt="Dont"
src="https://user-images.githubusercontent.com/1295166/277831673-8247c140-e819-4593-adf6-db5c8444fa78.png"
/>
<Caption>When multiple colored icons are used, the meaning behind each color becomes diluted.</Caption>
</Dont>
</DoDontContainer>

### Dividers

To enhance the readability of menus that contain numerous item descriptions, it is recommended to incorporate dividers. This can effectively prevent the menu from becoming overwhelming.
Expand Down
Loading